Summary: | fast/canvas/webgl/get-active-test.html failed in Chrome Mac | ||||||
---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Zhenyao Mo <zmo> | ||||
Component: | WebGL | Assignee: | Zhenyao Mo <zmo> | ||||
Status: | RESOLVED FIXED | ||||||
Severity: | Normal | CC: | cmarrin, commit-queue, dglazkov, gman, kbr, oliver | ||||
Priority: | P2 | ||||||
Version: | 528+ (Nightly build) | ||||||
Hardware: | PC | ||||||
OS: | OS X 10.5 | ||||||
Attachments: |
|
Description
Zhenyao Mo
2010-06-11 13:56:47 PDT
Will roll out the failing part first, then investigate. Manually rolled out the failing part of the test: http://trac.webkit.org/changeset/61038 Will add it back once this bug is fixed. Created attachment 58838 [details]
patch
Please review this first. Commit will wait until command-buffer port in Chrome is fixed.
Comment on attachment 58838 [details]
patch
Argh. Thanks for fixing this.
Could you please fix the same bug in Chromium in src/chrome/renderer/webgraphicscontext3d_command_buffer_impl.cc ? Either that, or we should refactor the makeContextCurrent() calls into the GraphicsContext3DInternal class in WebKit/chromium/src/GraphicsContext3D.cpp so that ports don't need to remember to do this.
(In reply to comment #4) > (From update of attachment 58838 [details]) > Argh. Thanks for fixing this. > > Could you please fix the same bug in Chromium in src/chrome/renderer/webgraphicscontext3d_command_buffer_impl.cc ? Either that, or we should refactor the makeContextCurrent() calls into the GraphicsContext3DInternal class in WebKit/chromium/src/GraphicsContext3D.cpp so that ports don't need to remember to do this. Yes, I'll fix the command_buffer port. (In reply to comment #5) > (In reply to comment #4) > > (From update of attachment 58838 [details] [details]) > > Argh. Thanks for fixing this. > > > > Could you please fix the same bug in Chromium in src/chrome/renderer/webgraphicscontext3d_command_buffer_impl.cc ? Either that, or we should refactor the makeContextCurrent() calls into the GraphicsContext3DInternal class in WebKit/chromium/src/GraphicsContext3D.cpp so that ports don't need to remember to do this. > > Yes, I'll fix the command_buffer port. OK, thanks. This patch looks good, but we should consider refactoring where the makeCurrent() calls occur. Comment on attachment 58838 [details]
patch
ok.
Comment on attachment 58838 [details] patch Clearing flags on attachment: 58838 Committed r61471: <http://trac.webkit.org/changeset/61471> All reviewed patches have been landed. Closing bug. |