Bug 40489

Summary: Chromium shouldn't build inside the source directory
Product: WebKit Reporter: Eric Seidel (no email) <eric>
Component: Tools / TestsAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: dglazkov, fishd, jamesr, tkent, tony, yaar
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: PC   
OS: OS X 10.5   
Attachments:
Description Flags
Patch fishd: review+

Description Eric Seidel (no email) 2010-06-11 12:29:15 PDT 
Chromium shouldn't build inside the source directory

It breaks assumptions of some of our scripts at least:

Renaming WebKit/chromium/xcodebuild/DerivedSources/Debug/webcore/bindings/V8WebGLFloatArray.cpp to WebKit/chromium/xcodebuild/DerivedSources/Debug/webcore/bindings/V8WebGLFloat32Array.cpp
fatal: not under version control, source=WebKit/chromium/xcodebuild/DerivedSources/Debug/webcore/bindings/V8WebGLFloatArray.cpp, destination=WebKit/chromium/xcodebuild/DerivedSources/Debug/webcore/bindings/V8WebGLFloat32Array.cpp
Renaming WebKit/chromium/xcodebuild/DerivedSources/Debug/webkit/bindings/V8WebGLFloatArray.h to WebKit/chromium/xcodebuild/DerivedSources/Debug/webkit/bindings/V8WebGLFloat32Array.h
fatal: not under version control, source=WebKit/chromium/xcodebuild/DerivedSources/Debug/webkit/bindings/V8WebGLFloatArray.h, destination=WebKit/chromium/xcodebuild/DerivedSources/Debug/webkit/bindings/V8WebGLFloat32Array.h
Renaming WebKit/chromium/xcodebuild/WebCore.build/Debug/webcore.build/Objects-normal/i386/V8WebGLFloatArrayCustom.o to WebKit/chromium/xcodebuild/WebCore.build/Debug/webcore.build/Objects-normal/i386/V8WebGLFloat32ArrayCustom.o
fatal: not under version control, source=WebKit/chromium/xcodebuild/WebCore.build/Debug/webcore.build/Objects-normal/i386/V8WebGLFloatArrayCustom.o, destination=WebKit/chromium/xcodebuild/WebCore.build/Debug/webcore.build/Objects-normal/i386/V8WebGLFloat32ArrayCustom.o
Renaming WebKit/chromium/xcodebuild/WebCore.build/Debug/webcore.build/Objects-normal/i386/WebGLFloatArray.o to WebKit/chromium/xcodebuild/WebCore.build/Debug/webcore.build/Objects-normal/i386/WebGLFloat32Array.o
fatal: not under version control, source=WebKit/chromium/xcodebuild/WebCore.build/Debug/webcore.build/Objects-normal/i386/WebGLFloatArray.o, destination=WebKit/chromium/xcodebuild/WebCore.build/Debug/webcore.build/Objects-normal/i386/WebGLFloat32Array.o
Died at /Projects/WebKit/WebKitTools/Scripts/do-webcore-rename line 210.
Comment 1 Eric Seidel (no email) 2010-06-11 12:30:38 PDT 
Related.  Chromium should either not unpack files inside the source directory, or it should gitignore/svn ignore them:


#	WebKit/chromium/app/
#	WebKit/chromium/base/
#	WebKit/chromium/chromium_deps/
#	WebKit/chromium/gfx/
#	WebKit/chromium/googleurl/
#	WebKit/chromium/gpu/
#	WebKit/chromium/media/
#	WebKit/chromium/net/
#	WebKit/chromium/sdch/
#	WebKit/chromium/skia/
#	WebKit/chromium/testing/
#	WebKit/chromium/third_party/
#	WebKit/chromium/tools/
#	WebKit/chromium/v8/
#	WebKit/chromium/webkit/
Comment 2 Tony Chang 2010-06-13 16:57:14 PDT 
I think we can just svn/git ignore the related directories.  I seems better that WebKit Mac and WebKit Chromium Mac build into different directories.  WebKit Chromium Mac happens to use WebKit/chromium/xcodebuild.
Comment 3 Tony Chang 2010-06-13 18:57:50 PDT 
Created attachment 58614 [details]
Patch
Comment 4 Tony Chang 2010-06-13 18:59:07 PDT 
svn diff shows:

Property changes on: .
___________________________________________________________________
Modified: svn:ignore
   - configure
depcomp
compile
config.guess
GNUmakefile.in
config.sub
ltmain.sh
aconfig.h.in
autom4te.cache
missing
aclocal.m4
install-sh

   + configure
depcomp
compile
config.guess
GNUmakefile.in
config.sub
ltmain.sh
aconfig.h.in
autom4te.cache
missing
aclocal.m4
install-sh
out
Makefile.chromium



Property changes on: WebKit/chromium
___________________________________________________________________
Added: svn:ignore
   + app
base
build
chromium_deps
gfx
googleurl
gpu
media
net
sdch
skia
testing
third_party
tools
v8
webkit
xcodebuild
Comment 5 Tony Chang 2010-06-14 17:00:45 PDT 
Committed r61162: <http://trac.webkit.org/changeset/61162>
Comment 6 Tony Chang 2010-06-14 17:05:26 PDT 
r61162 Adds the directories to svn:ignore, however, some scripts will still error out.  For example, do-webcore-rename will still crawl every file in WebKit.

It would probably take some effort to unpack in a different directory.  I'm not sure how hard it is to move the build directory on Mac/Win (on Linux, I already moved it to the top level for correctness issues with the Makefile).  It might be easier to make the scripts skip these directories.