Bug 40455

Summary: Refactoring the Clipboard class to abstract out platform-specific logic
Product: WebKit Reporter: Daniel Cheng <dcheng>
Component: HTML EditingAssignee: Nobody <webkit-unassigned>
Status: RESOLVED INVALID    
Severity: Normal CC: darin, dimich, jianli, tony
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: PC   
OS: OS X 10.5   
Bug Depends on: 40515, 40540    
Bug Blocks:    
Attachments:
Description Flags
Giant mega-patch none

Daniel Cheng
Reported 2010-06-10 17:44:21 PDT
The clipboard class today is a mish-mash of logic that's used for both copy and paste and dragging, with a lot of platform-specific logic embedded in DOM code. The proposed patch moves the platform-specific logic into the ClipboardData abstraction. Platforms can define different implementations of ClipboardData in order to read from the system clipboard or from platform drag-and-drop data. Eventually, if everyone moves to using ClipboardData, the various DragData*.cpp implementations can probably be consolidated as well. This is just a patch to get some feedback on the general approach. I'd break this patch up into several smaller ones when it comes time to land it.
Attachments
Giant mega-patch (119.61 KB, patch)
2010-06-10 18:00 PDT, Daniel Cheng 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Daniel Cheng
Comment 1 2010-06-10 18:00:04 PDT
Created attachment 58428 [details] Giant mega-patch
Note You need to log in before you can comment on or make changes to this bug.