Summary: | Window object should have CanvasGradient and CanvasPattern | ||||||||||||
---|---|---|---|---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Andreas Kling <kling> | ||||||||||
Component: | WebCore JavaScript | Assignee: | Nobody <webkit-unassigned> | ||||||||||
Status: | RESOLVED FIXED | ||||||||||||
Severity: | Normal | CC: | commit-queue | ||||||||||
Priority: | P2 | Keywords: | HTML5 | ||||||||||
Version: | 528+ (Nightly build) | ||||||||||||
Hardware: | All | ||||||||||||
OS: | All | ||||||||||||
Attachments: |
|
Description
Andreas Kling
2010-06-09 16:54:22 PDT
Created attachment 58309 [details]
Proposed patch
Comment on attachment 58309 [details]
Proposed patch
LGTM, r=me. If it passes all bots you can cq+ it.
Comment on attachment 58309 [details] Proposed patch Rejecting patch 58309 from commit-queue. andreas.kling@nokia.com does not have committer permissions according to http://trac.webkit.org/browser/trunk/WebKitTools/Scripts/webkitpy/common/config/committers.py. - If you do not have committer rights please read http://webkit.org/coding/contributing.html for instructions on how to use bugzilla flags. - If you have committer rights please correct the error in WebKitTools/Scripts/webkitpy/common/config/committers.py by adding yourself to the file (no review needed). Due to bug 30084 the commit-queue will require a restart after your change. Please contact eseidel@chromium.org to request a commit-queue restart. After restart the commit-queue will correctly respect your committer rights. Comment on attachment 58309 [details] Proposed patch Rejecting patch 58309 from commit-queue. Failed to run "[u'/Users/eseidel/Projects/CommitQueue/WebKitTools/Scripts/svn-apply', u'--reviewer', u'Kenneth Rohde Christiansen', u'--force']" exit_code: 1 Last 500 characters of output: xt patching file LayoutTests/canvas/philip/tests/2d.pattern.basic.type-expected.txt patching file LayoutTests/platform/mac/Skipped patching file LayoutTests/platform/qt/Skipped Hunk #1 FAILED at 5331. 1 out of 1 hunk FAILED -- saving rejects to file LayoutTests/platform/qt/Skipped.rej patching file WebCore/ChangeLog Hunk #1 succeeded at 1 with fuzz 3. patching file WebCore/html/canvas/CanvasGradient.idl patching file WebCore/html/canvas/CanvasPattern.idl patching file WebCore/page/DOMWindow.idl Full output: http://webkit-commit-queue.appspot.com/results/3225135 Created attachment 58466 [details]
Same patch rebased
Comment on attachment 58466 [details] Same patch rebased Rejecting patch 58466 from commit-queue. Failed to run "['WebKitTools/Scripts/run-webkit-tests', '--no-launch-safari', '--exit-after-n-failures=1', '--ignore-tests', 'compositing', '--quiet']" exit_code: 1 Last 500 characters of output: prendertree Compiling Java tests make: Nothing to be done for `default'. Running tests from /Users/eseidel/Projects/CommitQueue/LayoutTests Skipped list contained 'compositing/iframes/composited-iframe.html', but no file of that name could be found Testing 19084 test cases. fast/dom/dom-constructors.html -> failed Exiting early after 1 failures. 6300 tests run. 106.00s total testing time 6299 test cases (99%) succeeded 1 test case (<1%) had incorrect layout 1 test case (<1%) had stderr output Full output: http://webkit-commit-queue.appspot.com/results/3208283 Created attachment 58560 [details]
Proposed patch v3
Same patch with relevant tests rebaselined.
Comment on attachment 58560 [details] Proposed patch v3 Rejecting patch 58560 from commit-queue. Failed to run "['WebKitTools/Scripts/run-webkit-tests', '--no-launch-safari', '--exit-after-n-failures=1', '--ignore-tests', 'compositing', '--quiet']" exit_code: 1 Last 500 characters of output: tree Compiling Java tests make: Nothing to be done for `default'. Running tests from /Users/eseidel/Projects/CommitQueue/LayoutTests Skipped list contained 'compositing/iframes/composited-iframe.html', but no file of that name could be found Testing 19091 test cases. fast/dom/prototype-inheritance-2.html -> failed Exiting early after 1 failures. 6404 tests run. 106.28s total testing time 6403 test cases (99%) succeeded 1 test case (<1%) had incorrect layout 1 test case (<1%) had stderr output Full output: http://webkit-commit-queue.appspot.com/results/3187360 Created attachment 58569 [details]
Proposed patch v4
Same patch with 2 additional tests rebaselined.. not having a mac to test on FTL. ;)
Comment on attachment 58569 [details] Proposed patch v4 Clearing flags on attachment: 58569 Committed r61071: <http://trac.webkit.org/changeset/61071> All reviewed patches have been landed. Closing bug. |