| Summary: | Add three more non-core Chromium builders to start testing DumpRenderTree. | ||||||
|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Dimitri Glazkov (Google) <dglazkov> | ||||
| Component: | New Bugs | Assignee: | Dimitri Glazkov (Google) <dglazkov> | ||||
| Status: | RESOLVED FIXED | ||||||
| Severity: | Normal | CC: | abarth, commit-queue, eric, tony, wsiegrist | ||||
| Priority: | P2 | ||||||
| Version: | 528+ (Nightly build) | ||||||
| Hardware: | Other | ||||||
| OS: | OS X 10.5 | ||||||
| Bug Depends on: | |||||||
| Bug Blocks: | 41057 | ||||||
| Attachments: |
|
||||||
|
Description
Dimitri Glazkov (Google)
2010-06-08 14:45:23 PDT
Created attachment 58187 [details]
Patch
From what I understand, these are non-core by default. Right? They will stay red for a while (we're still catching up on the implementation), but we're close enough to start monitoring progress. Comment on attachment 58187 [details] Patch Yes. core builders is a white-list: https://trac.webkit.org/browser/trunk/WebKitTools/Scripts/webkitpy/common/net/buildbot.py#L312 Comment on attachment 58187 [details]
Patch
rs=me
Comment on attachment 58187 [details]
Patch
let cq do it.
Comment on attachment 58187 [details] Patch Clearing flags on attachment: 58187 Committed r61469: <http://trac.webkit.org/changeset/61469> All reviewed patches have been landed. Closing bug. Buildbot master has been updated and password info sent to Dimitri. And on a side note, the whitelist for Chromium was very broad, so I had to make it more specific so these new builders were not considered core. See also <http://trac.webkit.org/changeset/61508>. I might have chosen to put "build" in the regex, but that's probably fine for now. (In reply to comment #9) > I might have chosen to put "build" in the regex, but that's probably fine for now. The regexp matches the builder names, which do not contain "build", and renaming your builders seemed outside my jurisdiction. Feel free to rename them so their name ends in (Build). I agree that the regexp could be a little more self-documenting. > renaming your builders seemed outside my jurisdiction.
"my" builders. Haha. :)
Hopefully we'll end up with separate build and test builders for Chromium.
|