Bug 40335

Summary: Add three more non-core Chromium builders to start testing DumpRenderTree.
Product: WebKit Reporter: Dimitri Glazkov (Google) <dglazkov>
Component: New BugsAssignee: Dimitri Glazkov (Google) <dglazkov>
Status: RESOLVED FIXED    
Severity: Normal CC: abarth, commit-queue, eric, tony, wsiegrist
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Other   
OS: OS X 10.5   
Bug Depends on:    
Bug Blocks: 41057    
Attachments:
Description Flags
Patch none

Dimitri Glazkov (Google)
Reported 2010-06-08 14:45:23 PDT
Add three more non-core Chromium builders to start testing DumpRenderTree.
Attachments
Patch (4.38 KB, patch)
2010-06-08 14:46 PDT, Dimitri Glazkov (Google) 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Dimitri Glazkov (Google)
Comment 1 2010-06-08 14:46:03 PDT
Created attachment 58187 [details] Patch
Dimitri Glazkov (Google)
Comment 2 2010-06-08 14:48:09 PDT
From what I understand, these are non-core by default. Right? They will stay red for a while (we're still catching up on the implementation), but we're close enough to start monitoring progress.
Eric Seidel (no email)
Comment 3 2010-06-08 14:50:33 PDT
Comment on attachment 58187 [details] Patch Yes. core builders is a white-list: https://trac.webkit.org/browser/trunk/WebKitTools/Scripts/webkitpy/common/net/buildbot.py#L312
Darin Adler
Comment 4 2010-06-12 17:50:37 PDT
Comment on attachment 58187 [details] Patch rs=me
Dimitri Glazkov (Google)
Comment 5 2010-06-18 09:26:10 PDT
Comment on attachment 58187 [details] Patch let cq do it.
WebKit Commit Bot
Comment 6 2010-06-19 00:12:54 PDT
Comment on attachment 58187 [details] Patch Clearing flags on attachment: 58187 Committed r61469: <http://trac.webkit.org/changeset/61469>
WebKit Commit Bot
Comment 7 2010-06-19 00:12:58 PDT
All reviewed patches have been landed. Closing bug.
William Siegrist
Comment 8 2010-06-20 12:02:14 PDT
Buildbot master has been updated and password info sent to Dimitri. And on a side note, the whitelist for Chromium was very broad, so I had to make it more specific so these new builders were not considered core. See also <http://trac.webkit.org/changeset/61508>.
Adam Barth
Comment 9 2010-06-20 12:43:51 PDT
I might have chosen to put "build" in the regex, but that's probably fine for now.
William Siegrist
Comment 10 2010-06-20 23:07:11 PDT
(In reply to comment #9) > I might have chosen to put "build" in the regex, but that's probably fine for now. The regexp matches the builder names, which do not contain "build", and renaming your builders seemed outside my jurisdiction. Feel free to rename them so their name ends in (Build). I agree that the regexp could be a little more self-documenting.
Adam Barth
Comment 11 2010-06-21 10:01:03 PDT
> renaming your builders seemed outside my jurisdiction. "my" builders. Haha. :) Hopefully we'll end up with separate build and test builders for Chromium.
Note You need to log in before you can comment on or make changes to this bug.