Summary: | [Qt] Text breaking is slow: enable ICU as an opt-in | ||||||||||||||
---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Noam Rosenthal <noam> | ||||||||||||
Component: | Text | Assignee: | Nobody <webkit-unassigned> | ||||||||||||
Status: | RESOLVED FIXED | ||||||||||||||
Severity: | Normal | CC: | abecsi, benjamin, commit-queue, hausmann, kenneth, kling, laszlo_gombos | ||||||||||||
Priority: | P2 | Keywords: | Performance, Qt, QtTriaged | ||||||||||||
Version: | 528+ (Nightly build) | ||||||||||||||
Hardware: | PC | ||||||||||||||
OS: | All | ||||||||||||||
Attachments: |
|
Description
Noam Rosenthal
2010-06-08 14:02:16 PDT
Created attachment 58178 [details]
compile flag for Qt+ICU
Comment on attachment 58178 [details]
compile flag for Qt+ICU
Please do not use c-style casts.
Created attachment 70529 [details]
Patch
Comment on attachment 70529 [details]
Patch
This patch is full of unrelated gunk :)
oops, sorry ;) will resubmit Created attachment 70534 [details]
Patch
No unrelated junk this time
Comment on attachment 70534 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=70534&action=review LGTM. Curious to see how much faster this is. :-) > JavaScriptCore/ChangeLog:10 > + Extra newline. Created attachment 70536 [details]
Patch
Removed extra line.
Comment on attachment 70536 [details] Patch Rejecting patch 70536 from commit-queue. Failed to run "['./WebKitTools/Scripts/webkit-patch', '--status-host=queues.webkit.org', 'land-attachment', '--force-clean', '--ignore-builders', '--quiet', '--non-interactive', '--parent-command=commit-queue', 70536]" exit_code: 1 Last 500 characters of output: ng: https://bugs.webkit.org/show_bug.cgi?id=40332&ctype=xml Processing 1 patch from 1 bug. Cleaning working directory Updating working directory Processing patch 70536 from bug 40332. Andreas Kling <kling@webkit.org> found in /Projects/CommitQueue/JavaScriptCore/ChangeLog does not appear to be a valid reviewer according to committers.py. ERROR: /Projects/CommitQueue/JavaScriptCore/ChangeLog neither lists a valid reviewer nor contains the string "Unreviewed" or "Rubber stamp" (case insensitive). Full output: http://queues.webkit.org/results/4371021 Had to put it on r? again after removing the extra line, because for some reason it didn't work automatically for me to add Andreas as a rev-by... Am I doing something wrong? Do not add review? in that case Comment on attachment 70536 [details] Patch Rejecting patch 70536 from commit-queue. Failed to run "['./WebKitTools/Scripts/webkit-patch', '--status-host=queues.webkit.org', 'land-attachment', '--force-clean', '--ignore-builders', '--quiet', '--non-interactive', '--parent-command=commit-queue', 70536]" exit_code: 1 Last 500 characters of output: ng: https://bugs.webkit.org/show_bug.cgi?id=40332&ctype=xml Processing 1 patch from 1 bug. Cleaning working directory Updating working directory Processing patch 70536 from bug 40332. Andreas Kling <kling@webkit.org> found in /Projects/CommitQueue/JavaScriptCore/ChangeLog does not appear to be a valid reviewer according to committers.py. ERROR: /Projects/CommitQueue/JavaScriptCore/ChangeLog neither lists a valid reviewer nor contains the string "Unreviewed" or "Rubber stamp" (case insensitive). Full output: http://queues.webkit.org/results/4409001 It's probably choking on the " <kling@webkit.org>" in the revby field. Created attachment 70719 [details]
Patch
Comment on attachment 70534 [details] Patch Cleared review+ from obsolete attachment 70534 [details] so that this bug does not appear in http://webkit.org/pending-commit. Comment on attachment 70719 [details] Patch Clearing flags on attachment: 70719 Committed r69773: <http://trac.webkit.org/changeset/69773> All reviewed patches have been landed. Closing bug. |