Bug 40332

Summary: [Qt] Text breaking is slow: enable ICU as an opt-in
Product: WebKit Reporter: Noam Rosenthal <noam>
Component: TextAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: abecsi, benjamin, commit-queue, hausmann, kenneth, kling, laszlo_gombos
Priority: P2 Keywords: Performance, Qt, QtTriaged
Version: 528+ (Nightly build)   
Hardware: PC   
OS: All   
Attachments:
Description Flags
compile flag for Qt+ICU
none
Patch
kling: review-
Patch
none
Patch
commit-queue: commit-queue-
Patch none

Noam Rosenthal
Reported 2010-06-08 14:02:16 PDT
Right now Qt is the only port that doesn't use ICU for text breaking. That causes bottlenecks in some use cases. Proposing to allow ICU as an option.
Attachments
compile flag for Qt+ICU (7.38 KB, patch)
2010-06-08 14:05 PDT, Noam Rosenthal 		no flags
DetailsFormatted DiffDiff
Patch (14.42 KB, patch)
2010-10-12 07:11 PDT, Noam Rosenthal 		kling: review-
DetailsFormatted DiffDiff
Patch (7.23 KB, patch)
2010-10-12 09:03 PDT, Noam Rosenthal 		no flags
DetailsFormatted DiffDiff
Patch (7.26 KB, patch)
2010-10-12 09:40 PDT, Noam Rosenthal 		commit-queue: commit-queue-
DetailsFormatted DiffDiff
Patch (7.22 KB, patch)
2010-10-14 02:10 PDT, Noam Rosenthal 		no flags
DetailsFormatted DiffDiff
Show Obsolete (4) View All Add attachment proposed patch, testcase, etc.
Noam Rosenthal
Comment 1 2010-06-08 14:05:48 PDT
Created attachment 58178 [details] compile flag for Qt+ICU
Eric Seidel (no email)
Comment 2 2010-06-12 19:00:20 PDT
Comment on attachment 58178 [details] compile flag for Qt+ICU Please do not use c-style casts.
Noam Rosenthal
Comment 3 2010-10-12 07:11:34 PDT
Created attachment 70529 [details] Patch
Andreas Kling
Comment 4 2010-10-12 07:20:46 PDT
Comment on attachment 70529 [details] Patch This patch is full of unrelated gunk :)
Noam Rosenthal
Comment 5 2010-10-12 09:00:44 PDT
oops, sorry ;) will resubmit
Noam Rosenthal
Comment 6 2010-10-12 09:03:34 PDT
Created attachment 70534 [details] Patch No unrelated junk this time
Andreas Kling
Comment 7 2010-10-12 09:30:25 PDT
Comment on attachment 70534 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=70534&action=review LGTM. Curious to see how much faster this is. :-) > JavaScriptCore/ChangeLog:10 > + Extra newline.
Noam Rosenthal
Comment 8 2010-10-12 09:40:11 PDT
Created attachment 70536 [details] Patch Removed extra line.
WebKit Commit Bot
Comment 9 2010-10-12 09:58:45 PDT
Comment on attachment 70536 [details] Patch Rejecting patch 70536 from commit-queue. Failed to run "['./WebKitTools/Scripts/webkit-patch', '--status-host=queues.webkit.org', 'land-attachment', '--force-clean', '--ignore-builders', '--quiet', '--non-interactive', '--parent-command=commit-queue', 70536]" exit_code: 1 Last 500 characters of output: ng: https://bugs.webkit.org/show_bug.cgi?id=40332&ctype=xml Processing 1 patch from 1 bug. Cleaning working directory Updating working directory Processing patch 70536 from bug 40332. Andreas Kling <kling@webkit.org> found in /Projects/CommitQueue/JavaScriptCore/ChangeLog does not appear to be a valid reviewer according to committers.py. ERROR: /Projects/CommitQueue/JavaScriptCore/ChangeLog neither lists a valid reviewer nor contains the string "Unreviewed" or "Rubber stamp" (case insensitive). Full output: http://queues.webkit.org/results/4371021
Noam Rosenthal
Comment 10 2010-10-12 14:18:37 PDT
Had to put it on r? again after removing the extra line, because for some reason it didn't work automatically for me to add Andreas as a rev-by... Am I doing something wrong?
Kenneth Rohde Christiansen
Comment 11 2010-10-12 16:27:29 PDT
Do not add review? in that case
WebKit Commit Bot
Comment 12 2010-10-12 17:48:22 PDT
Comment on attachment 70536 [details] Patch Rejecting patch 70536 from commit-queue. Failed to run "['./WebKitTools/Scripts/webkit-patch', '--status-host=queues.webkit.org', 'land-attachment', '--force-clean', '--ignore-builders', '--quiet', '--non-interactive', '--parent-command=commit-queue', 70536]" exit_code: 1 Last 500 characters of output: ng: https://bugs.webkit.org/show_bug.cgi?id=40332&ctype=xml Processing 1 patch from 1 bug. Cleaning working directory Updating working directory Processing patch 70536 from bug 40332. Andreas Kling <kling@webkit.org> found in /Projects/CommitQueue/JavaScriptCore/ChangeLog does not appear to be a valid reviewer according to committers.py. ERROR: /Projects/CommitQueue/JavaScriptCore/ChangeLog neither lists a valid reviewer nor contains the string "Unreviewed" or "Rubber stamp" (case insensitive). Full output: http://queues.webkit.org/results/4409001
Andreas Kling
Comment 13 2010-10-13 02:28:37 PDT
It's probably choking on the " <kling@webkit.org>" in the revby field.
Noam Rosenthal
Comment 14 2010-10-14 02:10:22 PDT
Created attachment 70719 [details] Patch
Eric Seidel (no email)
Comment 15 2010-10-14 07:18:37 PDT
Comment on attachment 70534 [details] Patch Cleared review+ from obsolete attachment 70534 [details] so that this bug does not appear in http://webkit.org/pending-commit.
WebKit Commit Bot
Comment 16 2010-10-14 09:57:13 PDT
Comment on attachment 70719 [details] Patch Clearing flags on attachment: 70719 Committed r69773: <http://trac.webkit.org/changeset/69773>
WebKit Commit Bot
Comment 17 2010-10-14 09:57:24 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.