Bug 40315

Summary: Vertex attributes enabled as arrays but not bound to buffers must generate INVALID_OPERATION
Product: WebKit Reporter: Kenneth Russell <kbr>
Component: WebGLAssignee: Zhenyao Mo <zmo>
Status: RESOLVED FIXED    
Severity: Normal CC: cmarrin, commit-queue, dglazkov, oliver, zmo
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: All   
OS: All   
Attachments:
Description Flags
patch none

Kenneth Russell
Reported 2010-06-08 11:47:40 PDT
Per recent WebGL specification changes, if a vertex attribute is enabled as an array but has not been bound to a buffer object by a pair of calls to bindBuffer / vertexAttribPointer, calls to drawArrays and drawElements must generate an INVALID_OPERATION error.
Attachments
patch (5.07 KB, patch)
2010-06-10 10:47 PDT, Zhenyao Mo 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Zhenyao Mo
Comment 1 2010-06-10 10:47:51 PDT
Created attachment 58386 [details] patch
Kenneth Russell
Comment 2 2010-06-10 17:23:26 PDT
Comment on attachment 58386 [details] patch Looks good.
Dimitri Glazkov (Google)
Comment 3 2010-06-10 21:33:08 PDT
Comment on attachment 58386 [details] patch ok, with a clean-up suggestion: WebCore/html/canvas/WebGLRenderingContext.cpp:2936 + m_vertexAttribState[indx].bufferBinding = m_boundArrayBuffer; Typically, we try not to abbreviate names.
WebKit Commit Bot
Comment 4 2010-06-11 05:16:29 PDT
Comment on attachment 58386 [details] patch Clearing flags on attachment: 58386 Committed r61006: <http://trac.webkit.org/changeset/61006>
WebKit Commit Bot
Comment 5 2010-06-11 05:16:35 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.