Bug 40260

Summary: [Qt] EditorQt.cpp has coding-style errors
Product: WebKit Reporter: Anders Bakken <agbakken>
Component: New BugsAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Trivial CC: benjamin, commit-queue, jedrzej.nowacki
Priority: P5 Keywords: EasyFix, Qt, QtTriaged
Version: 528+ (Nightly build)   
Hardware: Other   
OS: All   
Attachments:
Description Flags
Patch
levin: review-
Fixing previous patch submitted by Anders Bakken to fix the coding-style on EditorQt.cpp none

Description Anders Bakken 2010-06-07 13:05:42 PDT
[Qt] EditorQt.cpp has coding-style errors
Comment 1 Anders Bakken 2010-06-07 13:06:05 PDT
Created attachment 58078 [details]
Patch
Comment 2 David Levin 2010-06-09 09:14:52 PDT
Comment on attachment 58078 [details]
Patch

>+  No new tests. (OOPS!)
:(
Comment 3 Jędrzej Nowacki 2010-06-15 01:28:34 PDT
(In reply to comment #2)
> (From update of attachment 58078 [details])
> >+  No new tests. (OOPS!)
> :(
I don't think that you can test it :-) this is a coding style fix.
Comment 4 Jędrzej Nowacki 2010-06-15 04:15:32 PDT
I don't like it, it destroys history of changes. I think it is not in the we work with webkit, general policy is that code shouldn't be changed only for a style reason.
Comment 5 Rafael Brandao 2011-04-05 07:45:02 PDT
Created attachment 88232 [details]
Fixing previous patch submitted by Anders Bakken to fix the coding-style on EditorQt.cpp
Comment 6 Laszlo Gombos 2011-04-05 07:48:44 PDT
Comment on attachment 88232 [details]
Fixing previous patch submitted by Anders Bakken to fix the coding-style on EditorQt.cpp

r=me.
Comment 7 WebKit Commit Bot 2011-04-05 09:19:01 PDT
Comment on attachment 88232 [details]
Fixing previous patch submitted by Anders Bakken to fix the coding-style on EditorQt.cpp

Clearing flags on attachment: 88232

Committed r82944: <http://trac.webkit.org/changeset/82944>
Comment 8 WebKit Commit Bot 2011-04-05 09:19:07 PDT
All reviewed patches have been landed.  Closing bug.