Summary: | [Qt] EditorQt.cpp has coding-style errors | ||||||||
---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Anders Bakken <agbakken> | ||||||
Component: | New Bugs | Assignee: | Nobody <webkit-unassigned> | ||||||
Status: | RESOLVED FIXED | ||||||||
Severity: | Trivial | CC: | benjamin, commit-queue, jedrzej.nowacki | ||||||
Priority: | P5 | Keywords: | EasyFix, Qt, QtTriaged | ||||||
Version: | 528+ (Nightly build) | ||||||||
Hardware: | Other | ||||||||
OS: | All | ||||||||
Attachments: |
|
Description
Anders Bakken
2010-06-07 13:05:42 PDT
Created attachment 58078 [details]
Patch
Comment on attachment 58078 [details] Patch >+ No new tests. (OOPS!) :( (In reply to comment #2) > (From update of attachment 58078 [details]) > >+ No new tests. (OOPS!) > :( I don't think that you can test it :-) this is a coding style fix. I don't like it, it destroys history of changes. I think it is not in the we work with webkit, general policy is that code shouldn't be changed only for a style reason. Created attachment 88232 [details]
Fixing previous patch submitted by Anders Bakken to fix the coding-style on EditorQt.cpp
Comment on attachment 88232 [details]
Fixing previous patch submitted by Anders Bakken to fix the coding-style on EditorQt.cpp
r=me.
Comment on attachment 88232 [details] Fixing previous patch submitted by Anders Bakken to fix the coding-style on EditorQt.cpp Clearing flags on attachment: 88232 Committed r82944: <http://trac.webkit.org/changeset/82944> All reviewed patches have been landed. Closing bug. |