Summary: | [Qt] DragClientQt.h has coding-style errors | ||||||||||
---|---|---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Anders Bakken <agbakken> | ||||||||
Component: | New Bugs | Assignee: | Nancy Piedra <nancy.piedra> | ||||||||
Status: | RESOLVED FIXED | ||||||||||
Severity: | Trivial | CC: | benjamin, commit-queue, jedrzej.nowacki | ||||||||
Priority: | P5 | Keywords: | EasyFix, Qt, QtTriaged | ||||||||
Version: | 528+ (Nightly build) | ||||||||||
Hardware: | All | ||||||||||
OS: | All | ||||||||||
Attachments: |
|
Description
Anders Bakken
2010-06-07 11:42:20 PDT
Created attachment 58057 [details]
Patch
Comment on attachment 58057 [details] Patch > diff --git a/WebKit/qt/ChangeLog b/WebKit/qt/ChangeLog > index fd58b69e86393a34b81a1a00816128f063581aff..e92c597d08f9faf66169493657b31071107cfb39 100644 > --- a/WebKit/qt/ChangeLog > +++ b/WebKit/qt/ChangeLog > @@ -1,3 +1,12 @@ > +2010-06-07 Anders Bakken <agbakken@gmail.com> > + > + Reviewed by NOBODY (OOPS!). > + > + [Qt] DragClientQt.h has coding-style errors > + https://bugs.webkit.org/show_bug.cgi?id=40245 > + > + * WebCoreSupport/DragClientQt.h: > + > 2010-06-06 Antonio Gomes <tonikitoo@webkit.org>, Laszlo Gombos <laszlo.1.gombos@nokia.com> > > Reviewed by Kenneth Christiansen, Eric Seidel. > diff --git a/WebKit/qt/WebCoreSupport/DragClientQt.h b/WebKit/qt/WebCoreSupport/DragClientQt.h > index 4c831917c2218f514c962424eb88e6a2b014d344..08d9eb00b715c8d0c5e1fccd0014a3d19be99251 100644 > --- a/WebKit/qt/WebCoreSupport/DragClientQt.h > +++ b/WebKit/qt/WebCoreSupport/DragClientQt.h > @@ -23,6 +23,8 @@ > * OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE. > */ > > +#ifndef DragClientQt_h > +#define DragClientQt_h There should be a blank line here. > #include "DragClient.h" Ditto. > class QWebPage; Probably here too. > namespace WebCore { This isn't spelled out in the style guide but it is typical style, so as long as you have a patch focused on style.... Created attachment 87804 [details]
Fix style issues in DragClientQt.h
It has been a while since original patch was submitted so I created a patch.
Comment on attachment 87804 [details] Fix style issues in DragClientQt.h View in context: https://bugs.webkit.org/attachment.cgi?id=87804&action=review > Source/WebKit/qt/WebCoreSupport/DragClientQt.h:39 > virtual WebCore::DragDestinationAction actionMaskForDrag(DragData*); I guess the WebCore namespace is not needed here :) Created attachment 87843 [details]
Patch to style issues in DragClientQt.h
Added a 2nd patch based on review comments.
Comment on attachment 87843 [details] Patch to style issues in DragClientQt.h Clearing flags on attachment: 87843 Committed r82673: <http://trac.webkit.org/changeset/82673> All reviewed patches have been landed. Closing bug. |