Description
Antti Koivisto
2010-06-07 07:39:38 PDT
Created attachment 58029 [details]
initial patch
Loads and renders pages. No real Qt API, requires hitting C API to use.
Created attachment 58037 [details]
better mmap use, other fixes
Reuse mapped regions in UpdateChunk so we don't end up generating disk io all the time.
Created attachment 60226 [details]
RunLoop
not build yet
http://trac.webkit.org/changeset/62253 might have broken Qt Linux Release minimal, Qt Linux ARMv5 Release, and Qt Linux ARMv7 Release http://trac.webkit.org/changeset/62253 http://trac.webkit.org/changeset/62254 (for reverting some extra files) Created attachment 60231 [details]
WorkQueue
Created attachment 60233 [details]
EventFactory
Attachment 60231 [details] did not pass style-queue:
Failed to run "['WebKitTools/Scripts/check-webkit-style', '--no-squash']" exit_code: 1
WebKit2/Platform/qt/WorkQueueQt.cpp:27: Found header this file implements before WebCore config.h. Should be: config.h, primary header, blank line, and then alphabetically sorted. [build/include_order] [4]
WebKit2/Platform/qt/WorkQueueQt.cpp:31: Alphabetical sorting problem. [build/include_order] [4]
WebKit2/Platform/qt/WorkQueueQt.cpp:35: This { should be at the end of the previous line [whitespace/braces] [4]
Total errors found: 3 in 3 files
If any of these errors are false positives, please file a bug against check-webkit-style.
Attachment 60233 [details] did not pass style-queue:
Failed to run "['WebKitTools/Scripts/check-webkit-style', '--no-squash']" exit_code: 1
WebKit2/Shared/qt/WebEventFactory.cpp:27: Found header this file implements before WebCore config.h. Should be: config.h, primary header, blank line, and then alphabetically sorted. [build/include_order] [4]
WebKit2/Shared/qt/WebEventFactory.cpp:30: Alphabetical sorting problem. [build/include_order] [4]
WebKit2/Shared/qt/WebEventFactory.cpp:42: An else if statement should be written as an if statement when the prior "if" concludes with a return, break, continue or goto statement. [readability/control_flow] [4]
WebKit2/Shared/qt/WebEventFactory.cpp:54: A case label should not be indented, but line up with its switch statement. [whitespace/indent] [4]
WebKit2/Shared/qt/WebEventFactory.cpp:154: Extra space between int and nativeVirtualKeyCode [whitespace/declaration] [3]
Total errors found: 5 in 3 files
If any of these errors are false positives, please file a bug against check-webkit-style.
Comment on attachment 60233 [details]
EventFactory
r=me for WebEventFactory
qt/WebEventFactoryQt.cpp might be a better name for platform specific file (even though naming for other platforms is inconsistent)
WorkQueue: http://trac.webkit.org/changeset/62256 Created attachment 60234 [details]
Patch (EventFactory) for landing
Created attachment 60235 [details]
Initial Qt API for WK2
Comment on attachment 60235 [details]
Initial Qt API for WK2
wrong file
Created attachment 60236 [details]
Initial Qt API for WK2
Created attachment 60238 [details]
Connection
Created attachment 60239 [details]
Initial Qt API for WK2
Attachment 60239 [details] did not pass style-queue:
Failed to run "['WebKitTools/Scripts/check-webkit-style', '--no-squash']" exit_code: 1
Last 3072 characters of output:
e: config.h, primary header, blank line, and then alphabetically sorted. [build/include_order] [4]
WebKit2/UIProcess/API/qt/qwkgraphicswidget.cpp:24: Alphabetical sorting problem. [build/include_order] [4]
WebKit2/UIProcess/API/qt/qwkgraphicswidget.cpp:30: Alphabetical sorting problem. [build/include_order] [4]
WebKit2/UIProcess/API/qt/qwkgraphicswidget.cpp:31: Alphabetical sorting problem. [build/include_order] [4]
WebKit2/UIProcess/API/qt/qwkgraphicswidget.cpp:32: Alphabetical sorting problem. [build/include_order] [4]
WebKit2/UIProcess/API/qt/qwkgraphicswidget.cpp:33: wtf includes should be <wtf/file.h> instead of "wtf/file.h". [build/include] [4]
WebKit2/UIProcess/API/qt/qwkgraphicswidget.cpp:48: This { should be at the end of the previous line [whitespace/braces] [4]
WebKit2/UIProcess/API/qt/qwkgraphicswidget.cpp:52: _q_scaleChanged is incorrectly named. Don't use underscores in your identifier names. [readability/naming] [4]
WebKit2/UIProcess/API/qt/qwkgraphicswidget.cpp:271: QWKGraphicsWidgetPrivate::_q_scaleChanged is incorrectly named. Don't use underscores in your identifier names. [readability/naming] [4]
WebKit2/UIProcess/API/qt/qwkpage.cpp:21: Found header this file implements before WebCore config.h. Should be: config.h, primary header, blank line, and then alphabetically sorted. [build/include_order] [4]
WebKit2/UIProcess/API/qt/qwkpage.cpp:24: Alphabetical sorting problem. [build/include_order] [4]
WebKit2/UIProcess/API/qt/qwkpage.cpp:27: Alphabetical sorting problem. [build/include_order] [4]
WebKit2/UIProcess/API/qt/qwkpage.cpp:28: Alphabetical sorting problem. [build/include_order] [4]
WebKit2/UIProcess/API/qt/qwkpage.cpp:31: Alphabetical sorting problem. [build/include_order] [4]
WebKit2/UIProcess/API/qt/qwkpage.cpp:137: Declaration has space between type name and * in QAction *a [whitespace/declaration] [3]
WebKit2/UIProcess/API/qt/qwkpage.cpp:178: QWKPagePrivate::_q_webActionTriggered is incorrectly named. Don't use underscores in your identifier names. [readability/naming] [4]
WebKit2/UIProcess/API/qt/qwkpage.cpp:180: Declaration has space between type name and * in QAction *a [whitespace/declaration] [3]
WebKit2/UIProcess/API/qt/qwkpage.cpp:338: Declaration has space between type name and * in QAction *a [whitespace/declaration] [3]
WebKit2/UIProcess/API/qt/qwkpage.h:1: #ifndef header guard has wrong style, please use: qwkpage_h [build/header_guard] [5]
WebKit2/UIProcess/API/qt/qwkpage_p.h:26: wtf includes should be <wtf/file.h> instead of "wtf/file.h". [build/include] [4]
WebKit2/UIProcess/API/qt/qwkpage_p.h:26: Alphabetical sorting problem. [build/include_order] [4]
WebKit2/UIProcess/API/qt/qwkpage_p.h:27: Alphabetical sorting problem. [build/include_order] [4]
WebKit2/UIProcess/API/qt/qwkpage_p.h:28: Alphabetical sorting problem. [build/include_order] [4]
WebKit2/UIProcess/API/qt/qwkpage_p.h:61: _q_webActionTriggered is incorrectly named. Don't use underscores in your identifier names. [readability/naming] [4]
Total errors found: 28 in 7 files
If any of these errors are false positives, please file a bug against check-webkit-style.
Connection: http://trac.webkit.org/changeset/62257 Created attachment 60243 [details]
linux build fixes
Created attachment 60244 [details]
Initial Qt API for WK2
Renamed the class and sorted the files properly, it will still complain because of missing config.h etc
Attachment 60244 [details] did not pass style-queue:
Failed to run "['WebKitTools/Scripts/check-webkit-style', '--no-squash']" exit_code: 1
WebKit2/UIProcess/API/qt/qwkpage.cpp:21: Found header this file implements before WebCore config.h. Should be: config.h, primary header, blank line, and then alphabetically sorted. [build/include_order] [4]
WebKit2/UIProcess/API/qt/qwkpage.cpp:24: Alphabetical sorting problem. [build/include_order] [4]
WebKit2/UIProcess/API/qt/qwkpage.cpp:27: Alphabetical sorting problem. [build/include_order] [4]
WebKit2/UIProcess/API/qt/qwkpage.cpp:176: QWKPagePrivate::_q_webActionTriggered is incorrectly named. Don't use underscores in your identifier names. [readability/naming] [4]
WebKit2/UIProcess/API/qt/qgraphicswkview.h:7: Alphabetical sorting problem. [build/include_order] [4]
WebKit2/UIProcess/API/qt/qgraphicswkview.h:8: Alphabetical sorting problem. [build/include_order] [4]
WebKit2/UIProcess/API/qt/qgraphicswkview.cpp:21: Found header this file implements before WebCore config.h. Should be: config.h, primary header, blank line, and then alphabetically sorted. [build/include_order] [4]
WebKit2/UIProcess/API/qt/qgraphicswkview.cpp:48: _q_scaleChanged is incorrectly named. Don't use underscores in your identifier names. [readability/naming] [4]
WebKit2/UIProcess/API/qt/qgraphicswkview.cpp:267: QGraphicsWKViewPrivate::_q_scaleChanged is incorrectly named. Don't use underscores in your identifier names. [readability/naming] [4]
WebKit2/UIProcess/API/qt/qwkpage_p.h:27: Alphabetical sorting problem. [build/include_order] [4]
WebKit2/UIProcess/API/qt/qwkpage_p.h:30: Alphabetical sorting problem. [build/include_order] [4]
WebKit2/UIProcess/API/qt/qwkpage_p.h:61: _q_webActionTriggered is incorrectly named. Don't use underscores in your identifier names. [readability/naming] [4]
Total errors found: 12 in 7 files
If any of these errors are false positives, please file a bug against check-webkit-style.
Created attachment 60246 [details]
Initial Qt API for WK2 (w/o special stuff)
Attachment 60246 [details] did not pass style-queue:
Failed to run "['WebKitTools/Scripts/check-webkit-style', '--no-squash']" exit_code: 1
WebKit2/UIProcess/API/qt/qwkpage.cpp:21: Found header this file implements before WebCore config.h. Should be: config.h, primary header, blank line, and then alphabetically sorted. [build/include_order] [4]
WebKit2/UIProcess/API/qt/qwkpage.cpp:24: Alphabetical sorting problem. [build/include_order] [4]
WebKit2/UIProcess/API/qt/qwkpage.cpp:27: Alphabetical sorting problem. [build/include_order] [4]
WebKit2/UIProcess/API/qt/qwkpage.cpp:176: QWKPagePrivate::_q_webActionTriggered is incorrectly named. Don't use underscores in your identifier names. [readability/naming] [4]
WebKit2/UIProcess/API/qt/qgraphicswkview.h:7: Alphabetical sorting problem. [build/include_order] [4]
WebKit2/UIProcess/API/qt/qgraphicswkview.h:8: Alphabetical sorting problem. [build/include_order] [4]
WebKit2/UIProcess/API/qt/qgraphicswkview.cpp:21: Found header this file implements before WebCore config.h. Should be: config.h, primary header, blank line, and then alphabetically sorted. [build/include_order] [4]
WebKit2/UIProcess/API/qt/qwkpage_p.h:27: Alphabetical sorting problem. [build/include_order] [4]
WebKit2/UIProcess/API/qt/qwkpage_p.h:30: Alphabetical sorting problem. [build/include_order] [4]
WebKit2/UIProcess/API/qt/qwkpage_p.h:61: _q_webActionTriggered is incorrectly named. Don't use underscores in your identifier names. [readability/naming] [4]
Total errors found: 10 in 7 files
If any of these errors are false positives, please file a bug against check-webkit-style.
linux build fixes: http://trac.webkit.org/changeset/62260 Created attachment 60248 [details]
Export symbols on Linux with GCC
r=me for the Qt API classed (QGraphicsWKView and QWKPage). Note that this is still work in progress and not meant to be the final state of the API. Created attachment 60250 [details] (r62287 - p=kenneth, r=antti) Initial Qt API for WK2 for landing Created attachment 60251 [details]
UpdateChunk
Attachment 60251 [details] did not pass style-queue:
Failed to run "['WebKitTools/Scripts/check-webkit-style', '--no-squash']" exit_code: 1
WebKit2/Shared/qt/UpdateChunk.cpp:27: Found header this file implements before WebCore config.h. Should be: config.h, primary header, blank line, and then alphabetically sorted. [build/include_order] [4]
WebKit2/Shared/qt/UpdateChunk.h:32: Alphabetical sorting problem. [build/include_order] [4]
WebKit2/Shared/qt/UpdateChunk.h:35: Code inside a namespace should not be indented. [whitespace/indent] [4]
Total errors found: 3 in 3 files
If any of these errors are false positives, please file a bug against check-webkit-style.
UpdateChunk: http://trac.webkit.org/changeset/62261 Created attachment 60252 [details]
Default client impl.
Comment on attachment 60252 [details]
Default client impl.
r=me, with discussed changes.
Created attachment 60255 [details] (r62295 - p=kenneth, r=antti) Default client impl. for landing Comment on attachment 60234 [details] Patch (EventFactory) for landing Clearing flags on attachment: 60234 Committed r62263: <http://trac.webkit.org/changeset/62263> Comment on attachment 60248 [details] Export symbols on Linux with GCC Clearing flags on attachment: 60248 Committed r62267: <http://trac.webkit.org/changeset/62267> All reviewed patches have been landed. Closing bug. Created attachment 60264 [details]
Export symbols on Linux with GCC
Created attachment 60266 [details] (r62297 - p=kenneth, rs=weinig) Patch 'Export symbols on Linux with GCC' for landing We still have pending stuff Comment on attachment 60250 [details] (r62287 - p=kenneth, r=antti) Initial Qt API for WK2 for landing Landed in http://trac.webkit.org/changeset/62287 Comment on attachment 60255 [details] (r62295 - p=kenneth, r=antti) Default client impl. for landing Landed in http://trac.webkit.org/changeset/62295 Comment on attachment 60266 [details] (r62297 - p=kenneth, rs=weinig) Patch 'Export symbols on Linux with GCC' for landing Landed in http://trac.webkit.org/changeset/62297 Comment on attachment 60233 [details] EventFactory Cleared Antti Koivisto's review+ from obsolete attachment 60233 [details] so that this bug does not appear in http://webkit.org/pending-commit. Comment on attachment 60246 [details] Initial Qt API for WK2 (w/o special stuff) Cleared Antti Koivisto's review+ from obsolete attachment 60246 [details] so that this bug does not appear in http://webkit.org/pending-commit. Comment on attachment 60252 [details] Default client impl. Cleared Antti Koivisto's review+ from obsolete attachment 60252 [details] so that this bug does not appear in http://webkit.org/pending-commit. Created attachment 60512 [details]
ChunkedUpdateDrawingArea + Proxy
Attachment 60512 [details] did not pass style-queue:
Failed to run "['WebKitTools/Scripts/check-webkit-style', '--no-squash']" exit_code: 1
WebKit2/UIProcess/qt/ChunkedUpdateDrawingAreaProxyQt.cpp:27: Found header this file implements before WebCore config.h. Should be: config.h, primary header, blank line, and then alphabetically sorted. [build/include_order] [4]
WebKit2/UIProcess/qt/ChunkedUpdateDrawingAreaProxyQt.cpp:64: Missing space after , [whitespace/comma] [3]
WebKit2/WebProcess/WebPage/qt/ChunkedUpdateDrawingAreaQt.cpp:27: Found header this file implements before WebCore config.h. Should be: config.h, primary header, blank line, and then alphabetically sorted. [build/include_order] [4]
WebKit2/WebProcess/WebPage/qt/ChunkedUpdateDrawingAreaQt.cpp:39: Code inside a namespace should not be indented. [whitespace/indent] [4]
Total errors found: 4 in 4 files
If any of these errors are false positives, please file a bug against check-webkit-style.
Created attachment 60516 [details] ChunkedUpdateDrawingArea + Proxy (r62481 + 62483) make the stylebot happier Attachment 60516 [details] did not pass style-queue:
Failed to run "['WebKitTools/Scripts/check-webkit-style', '--no-squash']" exit_code: 1
WebKit2/UIProcess/qt/ChunkedUpdateDrawingAreaProxyQt.cpp:27: Found header this file implements before WebCore config.h. Should be: config.h, primary header, blank line, and then alphabetically sorted. [build/include_order] [4]
WebKit2/WebProcess/WebPage/qt/ChunkedUpdateDrawingAreaQt.cpp:27: Found header this file implements before WebCore config.h. Should be: config.h, primary header, blank line, and then alphabetically sorted. [build/include_order] [4]
Total errors found: 2 in 4 files
If any of these errors are false positives, please file a bug against check-webkit-style.
http://trac.webkit.org/changeset/62481 might have broken Qt Linux Release minimal, Qt Linux ARMv5 Release, and Qt Linux ARMv7 Release ChunkedUpdateDrawingArea + Proxy: http://trac.webkit.org/changeset/62481 http://trac.webkit.org/changeset/62483 (reverting project file change) Created attachment 60520 [details]
Qt process launcher
Attachment 60520 [details] did not pass style-queue:
Failed to run "['WebKitTools/Scripts/check-webkit-style', '--no-squash']" exit_code: 1
WebKit2/UIProcess/Launcher/qt/ProcessLauncherQt.cpp:27: Found header this file implements before WebCore config.h. Should be: config.h, primary header, blank line, and then alphabetically sorted. [build/include_order] [4]
Total errors found: 1 in 2 files
If any of these errors are false positives, please file a bug against check-webkit-style.
Comment on attachment 60520 [details] Qt process launcher r=me > + WebProcess::shared().initialize("foo", RunLoop::current()); "foo"? Created attachment 60521 [details]
Qt process launcher for landing
Created attachment 60523 [details]
Qt C API integration
Created attachment 60524 [details]
Qt C API integration
Attachment 60524 [details] did not pass style-queue:
Failed to run "['WebKitTools/Scripts/check-webkit-style', '--no-squash']" exit_code: 1
WebKit2/UIProcess/Launcher/qt/ProcessLauncherQt.cpp:27: Found header this file implements before WebCore config.h. Should be: config.h, primary header, blank line, and then alphabetically sorted. [build/include_order] [4]
Total errors found: 1 in 2 files
If any of these errors are false positives, please file a bug against check-webkit-style.
Created attachment 60525 [details]
Qt C API integration
Attachment 60525 [details] did not pass style-queue:
Failed to run "['WebKitTools/Scripts/check-webkit-style', '--no-squash']" exit_code: 1
WebKit2/UIProcess/API/cpp/qt/WKStringQt.cpp:21: Found header this file implements before WebCore config.h. Should be: config.h, primary header, blank line, and then alphabetically sorted. [build/include_order] [4]
WebKit2/UIProcess/API/cpp/qt/WKStringQt.cpp:25: Alphabetical sorting problem. [build/include_order] [4]
WebKit2/UIProcess/API/cpp/qt/WKStringQt.cpp:26: wtf includes should be <wtf/file.h> instead of "wtf/file.h". [build/include] [4]
WebKit2/UIProcess/API/cpp/qt/WKURLQt.cpp:21: Found header this file implements before WebCore config.h. Should be: config.h, primary header, blank line, and then alphabetically sorted. [build/include_order] [4]
WebKit2/UIProcess/API/cpp/qt/WKURLQt.cpp:25: Alphabetical sorting problem. [build/include_order] [4]
WebKit2/UIProcess/API/cpp/qt/WKURLQt.cpp:26: wtf includes should be <wtf/file.h> instead of "wtf/file.h". [build/include] [4]
Total errors found: 6 in 5 files
If any of these errors are false positives, please file a bug against check-webkit-style.
Comment on attachment 60521 [details] Qt process launcher for landing Clearing flags on attachment: 60521 Committed r62485: <http://trac.webkit.org/changeset/62485> Comment on attachment 60525 [details]
Qt C API integration
r=me
WKURLRef WKURLCreateWithQUrl(QUrl qURL);
WKStringRef WKStringCreateWithQString(QString qString);
these should probably use const QUrl& and const QString&
Created attachment 60526 [details]
Qt C API integration - for landing
Comment on attachment 60526 [details] Qt C API integration - for landing Clearing flags on attachment: 60526 Committed r62486: <http://trac.webkit.org/changeset/62486> All reviewed patches have been landed. Closing bug. Created attachment 60528 [details]
WebErrors
Attachment 60528 [details] did not pass style-queue:
Failed to run "['WebKitTools/Scripts/check-webkit-style', '--no-squash']" exit_code: 1
WebKit2/WebProcess/WebCoreSupport/qt/WebErrorsQt.cpp:27: Found header this file implements before WebCore config.h. Should be: config.h, primary header, blank line, and then alphabetically sorted. [build/include_order] [4]
WebKit2/WebProcess/WebCoreSupport/qt/WebErrorsQt.cpp:32: Alphabetical sorting problem. [build/include_order] [4]
Total errors found: 2 in 2 files
If any of these errors are false positives, please file a bug against check-webkit-style.
Comment on attachment 60528 [details]
WebErrors
r=me
Created attachment 60531 [details]
Add stubs
Comment on attachment 60531 [details]
Add stubs
r=me
Attachment 60531 [details] did not pass style-queue:
Failed to run "['WebKitTools/Scripts/check-webkit-style', '--no-squash']" exit_code: 1
WebKit2/WebProcess/InjectedBundle/qt/InjectedBundleQt.cpp:26: Found header this file implements before WebCore config.h. Should be: config.h, primary header, blank line, and then alphabetically sorted. [build/include_order] [4]
WebKit2/UIProcess/Plugins/qt/PluginInfoStoreQt.cpp:26: Found header this file implements before WebCore config.h. Should be: config.h, primary header, blank line, and then alphabetically sorted. [build/include_order] [4]
Total errors found: 2 in 4 files
If any of these errors are false positives, please file a bug against check-webkit-style.
pending patches Comment on attachment 60528 [details] WebErrors Clearing flags on attachment: 60528 Committed r62491: <http://trac.webkit.org/changeset/62491> Comment on attachment 60531 [details] Add stubs Clearing flags on attachment: 60531 Committed r62494: <http://trac.webkit.org/changeset/62494> All reviewed patches have been landed. Closing bug. We are not quite done here yet, I believe. Comment on attachment 60520 [details] Qt process launcher Cleared Antti Koivisto's review+ from obsolete attachment 60520 [details] so that this bug does not appear in http://webkit.org/pending-commit. Comment on attachment 60525 [details] Qt C API integration Cleared Antti Koivisto's review+ from obsolete attachment 60525 [details] so that this bug does not appear in http://webkit.org/pending-commit. Created attachment 60617 [details] WebPageQt (r62639) Attachment 60617 [details] did not pass style-queue:
Failed to run "['WebKitTools/Scripts/check-webkit-style', '--no-squash']" exit_code: 1
WebKit2/WebProcess/WebPage/qt/WebPageQt.cpp:27: Found header this file implements before WebCore config.h. Should be: config.h, primary header, blank line, and then alphabetically sorted. [build/include_order] [4]
Total errors found: 1 in 2 files
If any of these errors are false positives, please file a bug against check-webkit-style.
Comment on attachment 60617 [details] WebPageQt (r62639) #ifndef VK_UNKNOWN 35 36 #define VK_UNKNOWN 0 why a newline between these? WebPageQt: http://trac.webkit.org/changeset/62639 (with less newlines) Created attachment 60713 [details]
Add Qt section to the prefix header
Created attachment 60719 [details]
Export some event conversion functions needed for WebKit2
Comment on attachment 60713 [details]
Add Qt section to the prefix header
Jesus told me that because we don't include the Logging.h via config.h with --video is not compiling. We might want to include that here.
Created attachment 60722 [details]
MiniBrowser
Key event function exports: http://trac.webkit.org/changeset/62654 Attachment 60722 [details] did not pass style-queue:
Failed to run "['WebKitTools/Scripts/check-webkit-style', '--no-squash']" exit_code: 1
WebKitTools/MiniBrowser/qt/BrowserWindow.cpp:29: Found header this file implements before WebCore config.h. Should be: config.h, primary header, blank line, and then alphabetically sorted. [build/include_order] [4]
WebKitTools/MiniBrowser/qt/BrowserWindow.h:32: Alphabetical sorting problem. [build/include_order] [4]
WebKitTools/MiniBrowser/qt/BrowserWindow.h:34: Alphabetical sorting problem. [build/include_order] [4]
WebKitTools/MiniBrowser/qt/BrowserWindow.h:35: Alphabetical sorting problem. [build/include_order] [4]
WebKitTools/MiniBrowser/qt/main.cpp:28: Found other header before WebCore config.h. Should be: config.h, primary header, blank line, and then alphabetically sorted. [build/include_order] [4]
WebKitTools/MiniBrowser/qt/main.cpp:29: Alphabetical sorting problem. [build/include_order] [4]
WebKitTools/MiniBrowser/qt/main.cpp:31: Place brace on its own line for function definitions. [whitespace/braces] [4]
Total errors found: 7 in 4 files
If any of these errors are false positives, please file a bug against check-webkit-style.
WebKit2prefix: http://trac.webkit.org/changeset/ Comment on attachment 60722 [details]
MiniBrowser
r=me
Comment on attachment 60722 [details] MiniBrowser Rejecting patch 60722 from commit-queue. Found no modified ChangeLogs, cannot create a commit message. All changes require a ChangeLog. See: http://webkit.org/coding/contributing.html Created attachment 60870 [details]
a bunch of minor build fixes
Attachment 60870 [details] did not pass style-queue:
Failed to run "['WebKitTools/Scripts/check-webkit-style', '--no-squash']" exit_code: 1
WebKit2/Shared/qt/WebEventFactoryQt.cpp:27: Found header this file implements before WebCore config.h. Should be: config.h, primary header, blank line, and then alphabetically sorted. [build/include_order] [4]
WebKit2/UIProcess/API/qt/qwkpage.cpp:24: Alphabetical sorting problem. [build/include_order] [4]
WebKit2/UIProcess/API/qt/ClientImpl.cpp:20: Found header this file implements before WebCore config.h. Should be: config.h, primary header, blank line, and then alphabetically sorted. [build/include_order] [4]
Total errors found: 3 in 8 files
If any of these errors are false positives, please file a bug against check-webkit-style.
Comment on attachment 60870 [details]
a bunch of minor build fixes
wooh more upstreaming :-)
Comment on attachment 60870 [details] a bunch of minor build fixes some build fixes: http://trac.webkit.org/changeset/62788 Looks like that patch really is missing a ChangeLog... Comment on attachment 60870 [details]
a bunch of minor build fixes
+ friend class QGraphicsWKViewtPrivate;
I found a bug here, you are suffixing tPrivate and not Private
Created attachment 60952 [details]
MiniBrowser patch for landing
Comment on attachment 60722 [details] MiniBrowser Cleared Antti Koivisto's review+ from obsolete attachment 60722 [details] so that this bug does not appear in http://webkit.org/pending-commit. Comment on attachment 60952 [details] MiniBrowser patch for landing Clearing flags on attachment: 60952 Committed r62956: <http://trac.webkit.org/changeset/62956> All reviewed patches have been landed. Closing bug. |