AX: link won't return linked element if URL contains #

• Component: Accessibility
• Status: RESOLVED FIXED

[chris fleizach]

If you click on an internal link, so that the document URL contains a frament in it, subsequent calls to ask for linkedElements will not work

[chris fleizach]

So i don't forget

Index: WebCore/accessibility/AccessibilityRenderObject.cpp
===================================================================
--- WebCore/accessibility/AccessibilityRenderObject.cpp	(revision 230881)
+++ WebCore/accessibility/AccessibilityRenderObject.cpp	(working copy)
@@ -1247,7 +1247,9 @@ AccessibilityObject* AccessibilityRender
     
     // check if URL is the same as current URL
     linkURL.removeFragmentIdentifier();
-    if (m_renderer->document()->url() != linkURL)
+    KURL documentURL = m_renderer->document()->url();
+    documentURL.removeFragmentIdentifier();
+    if (documentURL != linkURL)
         return 0;

[chris fleizach]

Created attachment 58486 [details]
Patch

[WebKit Review Bot]

Attachment 58486 [details] did not build on gtk:
Build output: http://webkit-commit-queue.appspot.com/results/3222217

[chris fleizach]

Created attachment 58489 [details]
Patch

[WebKit Review Bot]

Attachment 58486 [details] did not build on win:
Build output: http://webkit-commit-queue.appspot.com/results/3238275

[Darin Adler]

Comment on attachment 58489 [details]
Patch

>      linkURL.removeFragmentIdentifier();
> -    if (m_renderer->document()->url() != linkURL)
> +    KURL documentURL = m_renderer->document()->url();
> +    documentURL.removeFragmentIdentifier();
> +    if (documentURL != linkURL)
>          return 0;

There's also a equalIgnoringFragmentIdentifier function in KURL.h that can be used for cases like this.

[chris fleizach]

http://trac.webkit.org/changeset/61103