Bug 40185

Summary: WebPageProxy should keep a weak reference to the PageClient
Product: WebKit Reporter: Ada Chan <adachan>
Component: WebKit2Assignee: Adam Roben (:aroben) <aroben>
Status: RESOLVED FIXED    
Severity: Normal CC: andersca, aroben, kenneth, sam, zoltan
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: PC   
OS: OS X 10.5   
Attachments:
Description Flags
Patch andersca: review+

Ada Chan
Reported 2010-06-04 13:21:09 PDT
Right now WebPageProxy stores an OwnPtr to the PageClient. That is not appropriate because WebPageProxy does not create the PageClient and it can be set to something that it should not own. For example, on Windows, it's currently being set to the WebView itself. This will cause a crash because WebView has a reference to WebPageProxy which has an OwnPtr to its PageClient, which is the WebView.
Attachments
Patch (3.42 KB, patch)
2010-07-27 14:01 PDT, Adam Roben (:aroben) 		andersca: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Adam Roben (:aroben)
Comment 1 2010-07-27 13:33:30 PDT
Seems like WKView should own the PageClient instead.
Adam Roben (:aroben)
Comment 2 2010-07-27 14:01:46 PDT
Created attachment 62743 [details] Patch
Adam Roben (:aroben)
Comment 3 2010-07-27 14:08:58 PDT
Committed r64155: <http://trac.webkit.org/changeset/64155>
Note You need to log in before you can comment on or make changes to this bug.