Summary: | Canvas createPattern(img, repetition) shouldn't throw INVALID_STATE_ERR when !img.complete | ||||||||||
---|---|---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Andreas Kling <kling> | ||||||||
Component: | WebCore Misc. | Assignee: | Nobody <webkit-unassigned> | ||||||||
Status: | RESOLVED FIXED | ||||||||||
Severity: | Normal | CC: | commit-queue, krit | ||||||||
Priority: | P2 | Keywords: | HTML5 | ||||||||
Version: | 528+ (Nightly build) | ||||||||||
Hardware: | All | ||||||||||
OS: | All | ||||||||||
Attachments: |
|
Description
Andreas Kling
2010-06-04 08:24:37 PDT
Created attachment 57883 [details]
Proposed patch
Note the lack of test due to a bug in HTMLImageElement's complete attribute.
This will be addressed in a subsequent patch.
Comment on attachment 57883 [details]
Proposed patch
lgtm. r=me
Created attachment 57900 [details]
Proposed patch v2
Oops! Turns out there IS a way to create an incomplete image and an existing test already covered it.
Updated patch with corrected test and ChangeLog.
Created attachment 57904 [details]
Proposed patch v3
Updated patch as per our discussion on IRC.
Test is now more verbose about what it's testing.
Comment on attachment 57904 [details]
Proposed patch v3
Great! r=me
Comment on attachment 57904 [details] Proposed patch v3 Clearing flags on attachment: 57904 Committed r60731: <http://trac.webkit.org/changeset/60731> All reviewed patches have been landed. Closing bug. |