Bug 40140 – Web Inspector: it would be better to print object properties in order of insertion.

• Component: Web Inspector (Deprecated)
• Status: RESOLVED FIXED

[Ilya Tikhonovsky]

we have dumpObject function in inspector-test.js which is used for dumping timeline records, resource records, etc.
It would be better to dump object properties in alphabetical order to avoid an inconsistency when we switch to native json serialization of timeline data.

[Ilya Tikhonovsky]

Created attachment 57813 [details]
[patch] initial version.

[Pavel Feldman]

Comment on attachment 57813 [details]
[patch] initial version.

I'd rather make sure that native serialization supports original enumerable properties order. It might require adding another vector into the object class, but we should totally do that.

[Ilya Tikhonovsky]

(In reply to comment #2)
> (From update of attachment 57813 [details])
> I'd rather make sure that native serialization supports original enumerable properties order. It might require adding another vector into the object class, but we should totally do that.

ECMA standard doesn't specify the order of enumerable properties but major browsers do that in the order of insertion.

http://bclary.com/2004/11/07/#a-12.6.4

[Ilya Tikhonovsky]

Created attachment 57880 [details]
[patch] second iteration

now we should push object properties to json string in order of insertion.

[Pavel Feldman]

Comment on attachment 57880 [details]
[patch] second iteration

WebCore/inspector/InspectorValues.h: 
 +      m_data.set(name, InspectorBasicValue::create(value));
what about calling set(name, InspectorBasicValue::create(value)) here and below?

[Ilya Tikhonovsky]

Committing to http://svn.webkit.org/repository/webkit/trunk ...
	M	WebCore/ChangeLog
	M	WebCore/inspector/InspectorValues.cpp
	M	WebCore/inspector/InspectorValues.h
Committed r60687