Summary: | Web Inspector: it would be better to print object properties in order of insertion. | ||||||||
---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Ilya Tikhonovsky <loislo> | ||||||
Component: | Web Inspector (Deprecated) | Assignee: | Nobody <webkit-unassigned> | ||||||
Status: | RESOLVED FIXED | ||||||||
Severity: | Normal | CC: | bweinstein, joepeck, keishi, pfeldman, pmuellr, rik, timothy, yurys | ||||||
Priority: | P2 | ||||||||
Version: | 528+ (Nightly build) | ||||||||
Hardware: | All | ||||||||
OS: | All | ||||||||
Attachments: |
|
Description
Ilya Tikhonovsky
2010-06-03 14:16:42 PDT
Created attachment 57813 [details]
[patch] initial version.
Comment on attachment 57813 [details]
[patch] initial version.
I'd rather make sure that native serialization supports original enumerable properties order. It might require adding another vector into the object class, but we should totally do that.
(In reply to comment #2) > (From update of attachment 57813 [details]) > I'd rather make sure that native serialization supports original enumerable properties order. It might require adding another vector into the object class, but we should totally do that. ECMA standard doesn't specify the order of enumerable properties but major browsers do that in the order of insertion. http://bclary.com/2004/11/07/#a-12.6.4 Created attachment 57880 [details]
[patch] second iteration
now we should push object properties to json string in order of insertion.
Comment on attachment 57880 [details]
[patch] second iteration
WebCore/inspector/InspectorValues.h:
+ m_data.set(name, InspectorBasicValue::create(value));
what about calling set(name, InspectorBasicValue::create(value)) here and below?
Committing to http://svn.webkit.org/repository/webkit/trunk ... M WebCore/ChangeLog M WebCore/inspector/InspectorValues.cpp M WebCore/inspector/InspectorValues.h Committed r60687 |