Summary: | AX: need ListItemRole and PresentationalRole | ||||||||||||||
---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | chris fleizach <cfleizach> | ||||||||||||
Component: | Accessibility | Assignee: | chris fleizach <cfleizach> | ||||||||||||
Status: | RESOLVED FIXED | ||||||||||||||
Severity: | Normal | CC: | bdakin, dglazkov, eric, mrobinson, webkit.review.bot, wsiegrist, xan.lopez | ||||||||||||
Priority: | P2 | ||||||||||||||
Version: | 528+ (Nightly build) | ||||||||||||||
Hardware: | PC | ||||||||||||||
OS: | OS X 10.5 | ||||||||||||||
Bug Depends on: | |||||||||||||||
Bug Blocks: | 40132 | ||||||||||||||
Attachments: |
|
Description
chris fleizach
2010-06-03 11:24:55 PDT
no functional changes. just prep work Created attachment 57796 [details]
Patch
Attachment 57796 [details] did not build on chromium: Build output: http://webkit-commit-queue.appspot.com/results/3102006 Created attachment 58083 [details]
patch
this should hopefully work for chomium too
Created attachment 58084 [details]
patch
now with correct changelogs
Created attachment 58086 [details]
patch
for some reason the last patch didn't take
weird only details is showing up Comment on attachment 58086 [details] patch > +Node* AccessibilityRenderObject::node() const > +{ > + if (!m_renderer) > + return 0; > + return m_renderer->node(); > +} What is this function for? It's added in the patch and not used. The patch otherwise seems great. review- because of the seemingly-unrelated change. (In reply to comment #8) > (From update of attachment 58086 [details]) > > +Node* AccessibilityRenderObject::node() const > > +{ > > + if (!m_renderer) > > + return 0; > > + return m_renderer->node(); > > +} > > What is this function for? It's added in the patch and not used. > > The patch otherwise seems great. review- because of the seemingly-unrelated change. That was part of the follow up patch. Forgot to take it out of this one Created attachment 58664 [details]
patch
Patch is same as before, but removes the not necessary node() function from this patch
Comment on attachment 58664 [details] patch > + (WebCore::): Lines like this should be deleted from the ChangeLog. And we should fix prepare-ChangeLog to not generate them. > + (RoleEntry::): Ditto. Seems to have caused a Gtk API test regression: ERROR:../../WebKit/gtk/tests/testatkroles.c:98:get_child_and_test_role: assertion failed: (child_role == role) Sheriffbot didn't notice because the buildbot seems to have not been notified of this revision. Not sure why or how. (In reply to comment #14) > Sheriffbot didn't notice because the buildbot seems to have not been notified of this revision. Not sure why or how. hopefully i can fix this tonite looks like http://trac.webkit.org/changeset/61176 fixed it |