Bug 40122

Summary: Web Inspector: Create resource for DebuggerScript.js.
Product: WebKit Reporter: Pavel Podivilov <podivilov>
Component: Web Inspector (Deprecated)Assignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: pfeldman, yurys
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: PC   
OS: OS X 10.5   
Attachments:
Description Flags
Proposed patch.
none
Proposed patch.
yurys: review-
Proposed patch. none

Pavel Podivilov
Reported 2010-06-03 08:45:29 PDT
Web Inspector: Create resource for DebuggerScript.js.
Attachments
Proposed patch. (1.07 KB, patch)
2010-06-03 08:48 PDT, Pavel Podivilov
no flags
Proposed patch. (1.71 KB, patch)
2010-06-03 10:26 PDT, Pavel Podivilov
yurys: review-
Proposed patch. (1.72 KB, patch)
2010-06-04 06:57 PDT, Pavel Podivilov
no flags
Pavel Podivilov
Comment 1 2010-06-03 08:48:11 PDT
Created attachment 57772 [details] Proposed patch.
Yury Semikhatsky
Comment 2 2010-06-03 08:51:16 PDT
Comment on attachment 57772 [details] Proposed patch. Can you as well add debuggerScriptSource method to WebDevToolsAgentClient in this patch?
Pavel Podivilov
Comment 3 2010-06-03 10:26:30 PDT
Created attachment 57786 [details] Proposed patch.
Yury Semikhatsky
Comment 4 2010-06-04 06:33:30 PDT
Comment on attachment 57786 [details] Proposed patch. WebKit/chromium/WebKit.grd:12 + <include name="IDR_DEVTOOLS_INJECT_DEBUG_JS" file="src\js\DebuggerScript.js" type="BINDATA"/> Either rename the file or the constant, they should have consistent names.
Pavel Podivilov
Comment 5 2010-06-04 06:57:32 PDT
Created attachment 57869 [details] Proposed patch.
Yury Semikhatsky
Comment 6 2010-06-04 06:58:32 PDT
Comment on attachment 57869 [details] Proposed patch. I'll land it.
Yury Semikhatsky
Comment 7 2010-06-04 07:07:14 PDT
Comment on attachment 57869 [details] Proposed patch. Clearing flags on attachment: 57869 Committed r60679: <http://trac.webkit.org/changeset/60679>
Yury Semikhatsky
Comment 8 2010-06-04 07:07:24 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.