Bug 40122

Summary: Web Inspector: Create resource for DebuggerScript.js.
Product: WebKit Reporter: Pavel Podivilov <podivilov>
Component: Web Inspector (Deprecated)Assignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: pfeldman, yurys
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: PC   
OS: OS X 10.5   
Attachments:
Description Flags
Proposed patch.
none
Proposed patch.
yurys: review-
Proposed patch. none

Description Pavel Podivilov 2010-06-03 08:45:29 PDT
Web Inspector: Create resource for DebuggerScript.js.
Comment 1 Pavel Podivilov 2010-06-03 08:48:11 PDT
Created attachment 57772 [details]
Proposed patch.
Comment 2 Yury Semikhatsky 2010-06-03 08:51:16 PDT
Comment on attachment 57772 [details]
Proposed patch.

Can you as well add debuggerScriptSource method to WebDevToolsAgentClient in this patch?
Comment 3 Pavel Podivilov 2010-06-03 10:26:30 PDT
Created attachment 57786 [details]
Proposed patch.
Comment 4 Yury Semikhatsky 2010-06-04 06:33:30 PDT
Comment on attachment 57786 [details]
Proposed patch.

WebKit/chromium/WebKit.grd:12
 +        <include name="IDR_DEVTOOLS_INJECT_DEBUG_JS" file="src\js\DebuggerScript.js" type="BINDATA"/>
Either rename the file or the constant, they should have consistent names.
Comment 5 Pavel Podivilov 2010-06-04 06:57:32 PDT
Created attachment 57869 [details]
Proposed patch.
Comment 6 Yury Semikhatsky 2010-06-04 06:58:32 PDT
Comment on attachment 57869 [details]
Proposed patch.

I'll land it.
Comment 7 Yury Semikhatsky 2010-06-04 07:07:14 PDT
Comment on attachment 57869 [details]
Proposed patch.

Clearing flags on attachment: 57869

Committed r60679: <http://trac.webkit.org/changeset/60679>
Comment 8 Yury Semikhatsky 2010-06-04 07:07:24 PDT
All reviewed patches have been landed.  Closing bug.