Bug 40116

Summary:

[Qt] Compilation fails when compiling against Qt 4.7 and Qt Mobility is installed

Product:

WebKit

Reporter:

Christian Kamm <christian.d.kamm>

Component:

WebKit Qt

Assignee:

Simon Hausmann <hausmann>

Status:

CLOSED FIXED

Severity:

Major

CC:

hausmann, ossy

Priority:

Keywords:

Qt, QtTriaged

Version:

528+ (Nightly build)

Hardware:

All

OS:

All

Attachments:

Description	Flags
[Qt] Compilation fails when compiling against Qt 4.7 and Qt Mobility is installed	vestbo: review+, vestbo: commit-queue+

Christian Kamm

Reported 2010-06-03 05:51:36 PDT

Since bearer management is contained in Qt 4.7, there's no need to pull in the legacy Qt Mobility Bearer Management code too. Patch: in WebCore/WebCore.pro @@ -2494,9 +2494,6 @@ contains(DEFINES, ENABLE_QT_BEARER=1) { SOURCES += \ platform/network/qt/NetworkStateNotifierQt.cpp - - CONFIG += mobility - MOBILITY += bearer } contains(DEFINES, ENABLE_SVG=1) { The deleted code had no effect if no mobility.prf was installed; but if it was installed though, it broke the build.

Attachments
[Qt] Compilation fails when compiling against Qt 4.7 and Qt Mobility is installed (1.38 KB, patch) 2010-06-04 05:40 PDT, Simon Hausmann	vestbo: review+ vestbo: commit-queue+	Details Formatted Diff Diff
View All Add attachment proposed patch, testcase, etc.

Simon Hausmann

Comment 1 2010-06-04 05:40:45 PDT

Created attachment 57866 [details] [Qt] Compilation fails when compiling against Qt 4.7 and Qt Mobility is installed

Simon Hausmann

Comment 2 2010-06-04 06:26:43 PDT

Committed r60677: <http://trac.webkit.org/changeset/60677>

Simon Hausmann

Comment 3 2010-06-04 08:05:53 PDT

Revision r60677 cherry-picked into qtwebkit-2.0 with commit 6db5de6d18c3ab8b74809303e4d79abacfc570a8

Note You need to log in before you can comment on or make changes to this bug.