| Summary: | Web Inspector: Implement JSON parsing for InspectorValue. | ||||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Pavel Podivilov <podivilov> | ||||||||||
| Component: | Web Inspector (Deprecated) | Assignee: | Nobody <webkit-unassigned> | ||||||||||
| Status: | RESOLVED FIXED | ||||||||||||
| Severity: | Normal | CC: | commit-queue, loislo, pfeldman | ||||||||||
| Priority: | P2 | ||||||||||||
| Version: | 528+ (Nightly build) | ||||||||||||
| Hardware: | PC | ||||||||||||
| OS: | OS X 10.5 | ||||||||||||
| Attachments: |
|
||||||||||||
|
Description
Pavel Podivilov
2010-06-02 08:22:01 PDT
Created attachment 57658 [details]
Proposed patch.
Created attachment 57661 [details]
Proposed patch.
Created attachment 57761 [details]
Proposed patch.
Comment on attachment 57761 [details]
Proposed patch.
Function names should start with lower case.
WebCore/inspector/InspectorValues.cpp:40
+ static const int kStackLimit = 100;
1000 ?
WebCore/inspector/InspectorValues.cpp:40
+ static const int kStackLimit = 100;
no k prefix, start from capital.
WebCore/inspector/InspectorValues.cpp:57
+ const char* const kNullString = "null";
no k prefix here and below.
WebCore/inspector/InspectorValues.cpp:63
+ while (start < end && *token != '\0' && *start++ == *token++) {
{ } on same line.
Overall looks good. Please make the code conform to the WebKit style guidelines.
Created attachment 57768 [details]
Proposed patch.
Comment on attachment 57768 [details]
Proposed patch.
This looks good to me. I think we need tests for this. We might need to wire this code to the actual inspector transport in order to use layout tests infrastructure...
Comment on attachment 57768 [details] Proposed patch. Clearing flags on attachment: 57768 Committed r60774: <http://trac.webkit.org/changeset/60774> All reviewed patches have been landed. Closing bug. |