Bug 3992

Summary: some elements draw selection when printing
Product: WebKit Reporter: Trey Matteson <trey>
Component: Layout and RenderingAssignee: Trey Matteson <trey>
Status: RESOLVED FIXED    
Severity: Normal    
Priority: P2    
Version: 412   
Hardware: Mac   
OS: OS X 10.4   
URL: http://www.nytimes.com/
Attachments:
Description Flags
proposed patch hyatt: review+

Trey Matteson
Reported 2005-07-13 22:05:30 PDT
Go to nytimes.com. Select All. Print. Choose Preview. The printing output has a large amount of the selection gray drawn all over it. The text elements seem smart enough not to draw selection, but the stuff between the text is all gray. Might be a regression from 1.2, but I'm not positive.
Attachments
proposed patch (4.29 KB, patch)
2005-07-13 22:13 PDT, Trey Matteson 		hyatt: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Trey Matteson
Comment 1 2005-07-13 22:05:56 PDT
This is also Radar #4083496
Trey Matteson
Comment 2 2005-07-13 22:13:40 PDT
Created attachment 2957 [details] proposed patch
Dave Hyatt
Comment 3 2005-07-25 14:34:04 PDT
Comment on attachment 2957 [details] proposed patch r=me It does occur to me, though, that another way to fix this might be to simply not do the PaintActionSelection phase at all when printing. Then none of the code that paints selection in the individual renderobjects would even have to check the printing state.
Justin Garcia
Comment 4 2005-07-26 19:09:36 PDT
Landing this
Note You need to log in before you can comment on or make changes to this bug.