Summary: | REGRESSION(58615): Scroll events are sent twice per keypress for ports that don't have a platformWidget scrollbar | ||||||||||
---|---|---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Nico Weber <thakis> | ||||||||
Component: | New Bugs | Assignee: | Nico Weber <thakis> | ||||||||
Status: | CLOSED FIXED | ||||||||||
Severity: | Normal | CC: | abarth, commit-queue, eric, hausmann, jamesr, ossy, simon.fraser, thakis, webkit-ews, webkit.review.bot | ||||||||
Priority: | P2 | ||||||||||
Version: | 528+ (Nightly build) | ||||||||||
Hardware: | Other | ||||||||||
OS: | OS X 10.5 | ||||||||||
Bug Depends on: | 40102 | ||||||||||
Bug Blocks: | |||||||||||
Attachments: |
|
Description
Nico Weber
2010-05-28 17:31:49 PDT
Created attachment 57397 [details]
Patch
+Simon, who merged the regressing patch into qtwebkit-2.0. This patch looks right, I missed this side effect in http://trac.webkit.org/changeset/58615. Attachment 57397 [details] did not build on qt: Build output: http://webkit-commit-queue.appspot.com/results/2632055 Created attachment 57399 [details]
Patch
This is http://crbug.com/43958 btw. Comment on attachment 57399 [details] Patch > + void scrollPositionChanged(); > + virtual void repaintFixedElementsPostScroll(); We don't use the term "postScroll" anywhere else, but we do use "afterScrolling", so I suggest you change the method name to use that. Created attachment 57673 [details]
Patch
Comment on attachment 57673 [details] Patch Earlier patch got r+ from smfr as can be seen here: https://bugs.webkit.org/show_activity.cgi?id=39918 Looks like webkit-patch clobbered that information. Comment on attachment 57673 [details] Patch Clearing flags on attachment: 57673 Committed r60591: <http://trac.webkit.org/changeset/60591> All reviewed patches have been landed. Closing bug. http://trac.webkit.org/changeset/60591 might have broken Qt Linux Release Revision r60591 cherry-picked into qtwebkit-2.0 with commit 7d41434425ce9c42e0fbb3640b13ee0669c9b6c7 (In reply to comment #13) > Revision r60591 cherry-picked into qtwebkit-2.0 with commit 7d41434425ce9c42e0fbb3640b13ee0669c9b6c7 editing/input/page-up-down-scrolls.html fails with QtWebKit, and is on Skipped list, see https://bugs.webkit.org/show_bug.cgi?id=40102 |