Bug 3991

Summary: JSC doesn't implement Array.prototype.toLocaleString()
Product: WebKit Reporter: Geoffrey Garen <ggaren>
Component: JavaScriptCoreAssignee: Geoffrey Garen <ggaren>
Status: RESOLVED FIXED    
Severity: Normal CC: oliver
Priority: P2    
Version: 412   
Hardware: Mac   
OS: OS X 10.4   
Attachments:
Description Flags
Patch
none
Patch mjs: review+

Geoffrey Garen
Reported 2005-07-13 18:25:34 PDT
ECMA spec: 15.4.4.3 Array.prototype.toLocaleString() The elements of the array are converted to strings using their toLocaleString methods, and these strings are then concatenated, separated by occurrences of a separator string that has been derived in an implementation-defined locale-specific way. The result of calling this function is intended to be analogous to the result of toString, except that the result of this function is intended to be locale-specific.
Attachments
Patch (3.50 KB, patch)
2005-07-13 18:27 PDT, Geoffrey Garen 		no flags
DetailsFormatted DiffDiff
Patch (1.52 KB, patch)
2005-07-13 18:32 PDT, Geoffrey Garen 		mjs: review+
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Geoffrey Garen
Comment 1 2005-07-13 18:26:23 PDT
Causes the following failure: ecma_3/Array/15.4.4.3-1.js
Geoffrey Garen
Comment 2 2005-07-13 18:27:41 PDT
Created attachment 2955 [details] Patch Fix. I think our case structure in this and other code is pretty ugly. Worth redoing?
Geoffrey Garen
Comment 3 2005-07-13 18:32:51 PDT
Created attachment 2956 [details] Patch Oops. Last patch had extra changes that were lingering in my tree.
Oliver Hunt
Comment 4 2005-07-13 23:58:05 PDT
If this gets landed can a comment be put in with bug 3539 as its patch will need to be updated work with this patch
Maciej Stachowiak
Comment 5 2005-07-19 14:04:53 PDT
Comment on attachment 2956 [details] Patch r=me
Note You need to log in before you can comment on or make changes to this bug.