| Summary: | [EFL] Allow building of shared core libraries | ||
|---|---|---|---|
| Product: | WebKit | Reporter: | Leandro Pereira <leandro> |
| Component: | New Bugs | Assignee: | Nobody <webkit-unassigned> |
| Status: | RESOLVED FIXED | ||
| Severity: | Normal | CC: | commit-queue, kenneth, lucas.de.marchi |
| Priority: | P2 | ||
| Version: | 528+ (Nightly build) | ||
| Hardware: | PC | ||
| OS: | Linux | ||
| Attachments: | |||
|
Description
Leandro Pereira
2010-05-28 14:00:06 PDT
Created attachment 57374 [details]
Allow building of shared core libraries
Comment on attachment 57374 [details]
Allow building of shared core libraries
The changes where you add files please put this in another patch in the future. Thanks!
Created attachment 57669 [details]
[EFL] Allow building of shared core libraries
Same patch, without unrelated changes that managed to slip in.
Created attachment 58032 [details]
[EFL] Allow building of shared core libraries
This patch was already reviewed by manyoso; uploading it again with his name on the reviewer line.
Comment on attachment 58032 [details] [EFL] Allow building of shared core libraries Rejecting patch 58032 from review queue. leandro@profusion.mobi does not have reviewer permissions according to http://trac.webkit.org/browser/trunk/WebKitTools/Scripts/webkitpy/common/config/committers.py. - If you do not have reviewer rights please read http://webkit.org/coding/contributing.html for instructions on how to use bugzilla flags. - If you have reviewer rights please correct the error in WebKitTools/Scripts/webkitpy/common/config/committers.py by adding yourself to the file (no review needed). Due to bug 30084 the commit-queue will require a restart after your change. Please contact eseidel@chromium.org to request a commit-queue restart. After restart the commit-queue will correctly respect your reviewer rights. Comment on attachment 58032 [details] [EFL] Allow building of shared core libraries Rejecting patch 58032 from commit-queue. leandro@profusion.mobi does not have committer permissions according to http://trac.webkit.org/browser/trunk/WebKitTools/Scripts/webkitpy/common/config/committers.py. - If you do not have committer rights please read http://webkit.org/coding/contributing.html for instructions on how to use bugzilla flags. - If you have committer rights please correct the error in WebKitTools/Scripts/webkitpy/common/config/committers.py by adding yourself to the file (no review needed). Due to bug 30084 the commit-queue will require a restart after your change. Please contact eseidel@chromium.org to request a commit-queue restart. After restart the commit-queue will correctly respect your committer rights. Comment on attachment 57374 [details] Allow building of shared core libraries Cleared Adam Treat's review+ from obsolete attachment 57374 [details] so that this bug does not appear in http://webkit.org/pending-commit. Created attachment 58048 [details]
Allow building of shared core libraries
Resending the patch, to reset the flags. (Turns out the bots aren't so smart. :))
Comment on attachment 58048 [details] Allow building of shared core libraries Clearing flags on attachment: 58048 Committed r60909: <http://trac.webkit.org/changeset/60909> All reviewed patches have been landed. Closing bug. |