Bug 39892

Summary:

Make NodeList getters take AtomicString instead of plain String

Product:

WebKit

Reporter:

anton muhin <antonm>

Component:

DOM

Assignee:

anton muhin <antonm>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

abarth, cdumez, commit-queue, darin, eric, mjs, sam, xan.lopez

Priority:

Version:

528+ (Nightly build)

Hardware:

All

OS:

All

Bug Depends on:

39921

Bug Blocks:

Attachments:

Description	Flags
Patch	none
Patch	none
with correct reviewed by	none

anton muhin

Reported 2010-05-28 11:40:56 PDT

Make NodeList getters take AtomicString instead of plain String

Attachments
Patch (2.33 KB, patch) 2010-05-28 11:46 PDT, anton muhin	no flags	Details Formatted Diff Diff
Patch (2.59 KB, patch) 2010-05-28 11:53 PDT, anton muhin	no flags	Details Formatted Diff Diff
with correct reviewed by (2.59 KB, patch) 2010-05-28 11:57 PDT, anton muhin	no flags	Details Formatted Diff Diff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.

anton muhin

Comment 1 2010-05-28 11:46:37 PDT

Created attachment 57355 [details] Patch

anton muhin

Comment 2 2010-05-28 11:47:41 PDT

Those methods turn String into AtomicString later. And this conversion is faster if underlying string is already atomic. That buys a small (~2-3%) speed up for Chromium on Dromaeo DOM Core. I don't know if Safari benefits from it. (Darin, you beat me at changine platform :) Is there a way to specify those parameters from command line in webkit-patch?)

Darin Adler

Comment 3 2010-05-28 11:49:47 PDT

Comment on attachment 57355 [details] Patch Would be nice if the change log said why this was a good change instead of just stating what the change is.

Darin Adler

Comment 4 2010-05-28 11:50:18 PDT

(In reply to comment #2) > (Darin, you beat me at changine platform :) Is there a way to specify those parameters from command line in webkit-patch?) Not that I know of.

anton muhin

Comment 5 2010-05-28 11:53:50 PDT

Created attachment 57356 [details] Patch

anton muhin

Comment 6 2010-05-28 11:56:18 PDT

(In reply to comment #4) > (In reply to comment #2) > > (Darin, you beat me at changine platform :) Is there a way to specify those parameters from command line in webkit-patch?) > > Not that I know of. I see, thanks. Uploaded a new patch with better message. I'll try to upload the next one with correct reviewed to start cq+.

anton muhin

Comment 7 2010-05-28 11:57:55 PDT

Created attachment 57357 [details] with correct reviewed by

WebKit Commit Bot

Comment 8 2010-05-29 04:18:43 PDT

Comment on attachment 57357 [details] with correct reviewed by Clearing flags on attachment: 57357 Committed r60405: <http://trac.webkit.org/changeset/60405>

WebKit Commit Bot

Comment 9 2010-05-29 04:18:49 PDT

All reviewed patches have been landed. Closing bug.

Eric Seidel (no email)

Comment 10 2010-05-29 10:35:21 PDT

Reopening since this was rolled out.

Darin Adler

Comment 11 2010-05-29 20:21:38 PDT

How did this break the build?

Darin Adler

Comment 12 2010-05-29 20:22:58 PDT

Looks to me like the problem with the GTK build was incorrect dependencies in the build system. If that is so, this is going to be an ongoing problem with multiple patches and I don't think rolling out patches is the right way to deal with it.

Xan Lopez

Comment 13 2010-05-30 07:46:09 PDT

(In reply to comment #12) > Looks to me like the problem with the GTK build was incorrect dependencies in the build system. If that is so, this is going to be an ongoing problem with multiple patches and I don't think rolling out patches is the right way to deal with it. The right way is to fix the bugs, right. I uploaded a patch to bug 39932 that seems to fix things; once that's in we can try again.

anton muhin

Comment 14 2010-05-31 06:09:50 PDT

(In reply to comment #13) > (In reply to comment #12) > > Looks to me like the problem with the GTK build was incorrect dependencies in the build system. If that is so, this is going to be an ongoing problem with multiple patches and I don't think rolling out patches is the right way to deal with it. > > The right way is to fix the bugs, right. I uploaded a patch to bug 39932 that seems to fix things; once that's in we can try again. Ok, I am trying to cq+ it again.

WebKit Commit Bot

Comment 15 2010-05-31 06:34:58 PDT

Comment on attachment 57357 [details] with correct reviewed by Clearing flags on attachment: 57357 Committed r60434: <http://trac.webkit.org/changeset/60434>

WebKit Commit Bot

Comment 16 2010-05-31 06:35:06 PDT

All reviewed patches have been landed. Closing bug.

Lucas Forschler

Comment 17 2019-02-06 09:03:38 PST

Mass moving XML DOM bugs to the "DOM" Component.

Note You need to log in before you can comment on or make changes to this bug.