Bug 39881

Summary:

AX: need to catch NSAccessibilityExceptions in DRT

Product:

WebKit

Reporter:

chris fleizach <cfleizach>

Component:

Accessibility

Assignee:

chris fleizach <cfleizach>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

abarth, bdakin, eric, webkit.review.bot

Priority:

Version:

528+ (Nightly build)

Hardware:

OS:

OS X 10.5

Attachments:

Description	Flags
patch	darin: review+

chris fleizach

Reported 2010-05-28 09:33:01 PDT

We need to catch NSAccessibilityExceptions in DRT. Normally these are caught in the AX Runtime on the mac, but because DRT is its own AX client, no one is there to catch these otherwise innocuous exceptions.

Attachments
patch (31.50 KB, patch) 2010-05-28 10:30 PDT, chris fleizach	darin: review+	Details Formatted Diff Diff
View All Add attachment proposed patch, testcase, etc.

chris fleizach

Comment 1 2010-05-28 10:30:27 PDT

Created attachment 57341 [details] patch

Darin Adler

Comment 2 2010-05-28 10:37:37 PDT

Comment on attachment 57341 [details] patch Don't we want to give the test access to the exception? Won't we want tests that expect exceptions and other tests that don't expect them? Maybe we can turn the exceptions into JavaScript exceptions? r=me as is

chris fleizach

Comment 3 2010-05-28 10:41:30 PDT

filed https://bugs.webkit.org/show_bug.cgi?id=39885 to handle darin's request. as of yet, no layout tests need to know about these exceptions, but its possible in the future

chris fleizach

Comment 4 2010-05-28 10:45:39 PDT

http://trac.webkit.org/changeset/60366

chris fleizach

Comment 5 2010-05-28 11:44:34 PDT

apparently tiger doesn't like having a NSMakeRange in a @try block. working on fix now

chris fleizach

Comment 6 2010-05-28 11:46:10 PDT

http://trac.webkit.org/changeset/60372

WebKit Review Bot

Comment 7 2010-05-28 11:47:42 PDT

http://trac.webkit.org/changeset/60366 might have broken Tiger Intel Release The following changes are on the blame list: http://trac.webkit.org/changeset/60368 http://trac.webkit.org/changeset/60369 http://trac.webkit.org/changeset/60370 http://trac.webkit.org/changeset/60366 http://trac.webkit.org/changeset/60367

WebKit Review Bot

Comment 8 2010-05-28 13:58:47 PDT

http://trac.webkit.org/changeset/60372 might have broken GTK Linux 32-bit Debug The following changes are on the blame list: http://trac.webkit.org/changeset/60371 http://trac.webkit.org/changeset/60372 http://trac.webkit.org/changeset/60373

Note You need to log in before you can comment on or make changes to this bug.