Bug 39781

Summary: [Qt] ClipboardQt.cpp has coding-style errors
Product: WebKit Reporter: Anders Bakken <agbakken>
Component: WebKit QtAssignee: Nobody <webkit-unassigned>
Severity: Normal CC: commit-queue, levin, peojala11
Priority: P2 Keywords: Qt, QtTriaged
Version: 528+ (Nightly build)   
Hardware: PC   
OS: All   
Description Flags
Patch that fixes the coding style issues
Patch none

Description Anders Bakken 2010-05-26 13:39:09 PDT
WebCore/platform/qt/ClipboardQt.cpp:32:  Alphabetical sorting problem.  [build/include_order] [4]
WebCore/platform/qt/ClipboardQt.cpp:42:  Alphabetical sorting problem.  [build/include_order] [4]
WebCore/platform/qt/ClipboardQt.cpp:52:  Alphabetical sorting problem.  [build/include_order] [4]
WebCore/platform/qt/ClipboardQt.cpp:229:  Should have a space between // and comment  [whitespace/comments] [4]
WebCore/platform/qt/ClipboardQt.cpp:236:  Declaration has space between type name and * in QPixmap *pixmap  [whitespace/declaration] [3]
Total errors found: 5 in 1 files
Comment 1 Anders Bakken 2010-05-26 14:47:30 PDT
Created attachment 57162 [details]
Patch that fixes the coding style issues
Comment 2 Petri Ojala 2010-05-26 21:54:20 PDT
Comment 3 David Levin 2010-05-27 11:10:50 PDT
Comment on attachment 57162 [details]
Patch that fixes the coding style issues

>   No new tests. (OOPS!)
Comment 4 Anders Bakken 2010-06-04 20:26:35 PDT
Created attachment 57957 [details]
Comment 5 Eric Seidel (no email) 2010-06-04 22:12:38 PDT
Comment on attachment 57957 [details]

What's this for?
     // WebCore::writeURL(m_writableDataObject.get(), url, title, true, false);
generally we don't commit commented-out code, it's possible that line should simply be removed.
Comment 6 WebKit Commit Bot 2010-06-09 12:13:08 PDT
Comment on attachment 57957 [details]

Clearing flags on attachment: 57957

Committed r60905: <http://trac.webkit.org/changeset/60905>
Comment 7 WebKit Commit Bot 2010-06-09 12:13:14 PDT
All reviewed patches have been landed.  Closing bug.