Summary: | [Qt] ClipboardQt.cpp has coding-style errors | ||||||||
---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Anders Bakken <agbakken> | ||||||
Component: | WebKit Qt | Assignee: | Nobody <webkit-unassigned> | ||||||
Status: | RESOLVED FIXED | ||||||||
Severity: | Normal | CC: | commit-queue, levin, peojala11 | ||||||
Priority: | P2 | Keywords: | Qt, QtTriaged | ||||||
Version: | 528+ (Nightly build) | ||||||||
Hardware: | PC | ||||||||
OS: | All | ||||||||
Attachments: |
|
Description
Anders Bakken
2010-05-26 13:39:09 PDT
Created attachment 57162 [details]
Patch that fixes the coding style issues
QtTriaged Comment on attachment 57162 [details] Patch that fixes the coding style issues > No new tests. (OOPS!) Ditto. Created attachment 57957 [details]
Patch
Comment on attachment 57957 [details]
Patch
What's this for?
// WebCore::writeURL(m_writableDataObject.get(), url, title, true, false);
generally we don't commit commented-out code, it's possible that line should simply be removed.
Comment on attachment 57957 [details] Patch Clearing flags on attachment: 57957 Committed r60905: <http://trac.webkit.org/changeset/60905> All reviewed patches have been landed. Closing bug. |