Bug 39780

Summary: [Qt] ContextMenuItemQt.cpp has coding-style errors
Product: WebKit Reporter: Anders Bakken <agbakken>
Component: WebKit QtAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, levin, peojala11
Priority: P2 Keywords: Qt, QtTriaged
Version: 528+ (Nightly build)   
Hardware: PC   
OS: All   
Attachments:
Description Flags
Patch that fixes the coding style issues
none
Patch none

Anders Bakken
Reported 2010-05-26 13:38:32 PDT
WebCore/platform/qt/ContextMenuItemQt.cpp:28: You should add a blank line after implementation file's own header. [build/include_order] [4] Total errors found: 1 in 1 files
Attachments
Patch that fixes the coding style issues (1.24 KB, patch)
2010-05-26 14:47 PDT, Anders Bakken 		no flags
DetailsFormatted DiffDiff
Patch (1.30 KB, patch)
2010-06-04 20:25 PDT, Anders Bakken 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Anders Bakken
Comment 1 2010-05-26 14:47:11 PDT
Created attachment 57161 [details] Patch that fixes the coding style issues
Petri Ojala
Comment 2 2010-05-26 21:53:40 PDT
QtTriaged
David Levin
Comment 3 2010-05-27 11:11:56 PDT
Comment on attachment 57161 [details] Patch that fixes the coding style issues > No new tests. (OOPS!) Ditto.
Anders Bakken
Comment 4 2010-06-04 20:25:28 PDT
Created attachment 57956 [details] Patch
WebKit Commit Bot
Comment 5 2010-06-05 05:15:39 PDT
Comment on attachment 57956 [details] Patch Clearing flags on attachment: 57956 Committed r60751: <http://trac.webkit.org/changeset/60751>
WebKit Commit Bot
Comment 6 2010-06-05 05:15:51 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.