Bug 39777

Summary: [Qt] DragDataQt.cpp has coding-style errors
Product: WebKit Reporter: Anders Bakken <agbakken>
Component: WebKit QtAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: abarth, commit-queue, eric, levin, peojala11, webkit.review.bot
Priority: P2 Keywords: Qt, QtTriaged
Version: 528+ (Nightly build)   
Hardware: PC   
OS: All   
Attachments:
Description Flags
Patch that fixes the coding style issues
none
Patch none

Anders Bakken
Reported 2010-05-26 13:37:09 PDT
WebCore/platform/qt/DragDataQt.cpp:37: Alphabetical sorting problem. [build/include_order] [4] Total errors found: 1 in 1 files
Attachments
Patch that fixes the coding style issues (1.31 KB, patch)
2010-05-26 14:46 PDT, Anders Bakken 		no flags
DetailsFormatted DiffDiff
Patch (1.37 KB, patch)
2010-06-04 20:21 PDT, Anders Bakken 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Anders Bakken
Comment 1 2010-05-26 14:46:07 PDT
Created attachment 57158 [details] Patch that fixes the coding style issues
Petri Ojala
Comment 2 2010-05-26 21:51:54 PDT
QtTriaged
David Levin
Comment 3 2010-05-27 11:12:54 PDT
Comment on attachment 57158 [details] Patch that fixes the coding style issues Not marked as patch :( > No new tests. (OOPS!) Ditto.
Anders Bakken
Comment 4 2010-06-04 20:21:35 PDT
Created attachment 57953 [details] Patch
WebKit Commit Bot
Comment 5 2010-06-05 04:50:12 PDT
Comment on attachment 57953 [details] Patch Clearing flags on attachment: 57953 Committed r60749: <http://trac.webkit.org/changeset/60749>
WebKit Commit Bot
Comment 6 2010-06-05 04:50:18 PDT
All reviewed patches have been landed. Closing bug.
WebKit Review Bot
Comment 7 2010-06-05 05:34:02 PDT
http://trac.webkit.org/changeset/60749 might have broken Tiger Intel Release
Note You need to log in before you can comment on or make changes to this bug.