Bug 39759

Summary: WidgetQt.cpp has coding-style errors
Product: WebKit Reporter: Anders Bakken <agbakken>
Component: WebKit QtAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, peojala11
Priority: P2 Keywords: Qt, QtTriaged
Version: 528+ (Nightly build)   
Hardware: PC   
OS: All   
Attachments:
Description Flags
Patch that fixes the coding style issues
none
Patch none

Description Anders Bakken 2010-05-26 13:23:59 PDT
WebCore/platform/qt/WidgetQt.cpp:41:  Alphabetical sorting problem.  [build/include_order] [4]
WebCore/platform/qt/WidgetQt.cpp:50:  Alphabetical sorting problem.  [build/include_order] [4]
WebCore/platform/qt/WidgetQt.cpp:52:  Alphabetical sorting problem.  [build/include_order] [4]
Total errors found: 3 in 1 files
Comment 1 Anders Bakken 2010-05-26 14:33:02 PDT
Created attachment 57139 [details]
Patch that fixes the coding style issues
Comment 2 David Levin 2010-05-26 17:52:22 PDT
Comment on attachment 57139 [details]
Patch that fixes the coding style issues


> +
> +        No new tests. (OOPS!)

You need to remove this.

Instead in this case, it should say something like "No functionality change, so no new tests."
Comment 3 Petri Ojala 2010-05-26 21:40:30 PDT
QtTriaged
Comment 4 Anders Bakken 2010-06-04 18:34:13 PDT
Created attachment 57934 [details]
Patch
Comment 5 WebKit Commit Bot 2010-06-04 22:39:49 PDT
Comment on attachment 57934 [details]
Patch

Clearing flags on attachment: 57934

Committed r60735: <http://trac.webkit.org/changeset/60735>
Comment 6 WebKit Commit Bot 2010-06-04 22:39:54 PDT
All reviewed patches have been landed.  Closing bug.