Bug 39752

Summary: [chromium] Windows key should be supported by NativeWebKeyboardEvent
Product: WebKit Reporter: Jay Civelli <jcivelli>
Component: WebKit Misc.Assignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, hbono, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: PC   
OS: OS X 10.5   
Attachments:
Description Flags
First version of patch none

Description Jay Civelli 2010-05-26 10:40:22 PDT
The left and right Windows keys (VK_LWIN and VK_RWIN) should be supported by NativeWebKeyboardEvent.
Comment 1 Jay Civelli 2010-05-26 10:57:21 PDT
Created attachment 57116 [details]
First version of patch
Comment 2 WebKit Review Bot 2010-05-26 11:35:39 PDT
Attachment 57116 [details] did not pass style-queue:

Failed to run "['WebKitTools/Scripts/check-webkit-style', '--no-squash']" exit_code: 1
Last 3072 characters of output:
e comments  [whitespace/comments] [5]
WebKit/chromium/src/gtk/WebInputEventFactory.cpp:183:  One space before end of line comments  [whitespace/comments] [5]
WebKit/chromium/src/gtk/WebInputEventFactory.cpp:184:  One space before end of line comments  [whitespace/comments] [5]
WebKit/chromium/src/gtk/WebInputEventFactory.cpp:185:  One space before end of line comments  [whitespace/comments] [5]
WebKit/chromium/src/gtk/WebInputEventFactory.cpp:186:  One space before end of line comments  [whitespace/comments] [5]
WebKit/chromium/src/gtk/WebInputEventFactory.cpp:187:  One space before end of line comments  [whitespace/comments] [5]
WebKit/chromium/src/gtk/WebInputEventFactory.cpp:188:  One space before end of line comments  [whitespace/comments] [5]
WebKit/chromium/src/gtk/WebInputEventFactory.cpp:189:  One space before end of line comments  [whitespace/comments] [5]
WebKit/chromium/src/gtk/WebInputEventFactory.cpp:190:  One space before end of line comments  [whitespace/comments] [5]
WebKit/chromium/src/gtk/WebInputEventFactory.cpp:191:  One space before end of line comments  [whitespace/comments] [5]
WebKit/chromium/src/gtk/WebInputEventFactory.cpp:192:  One space before end of line comments  [whitespace/comments] [5]
WebKit/chromium/src/gtk/WebInputEventFactory.cpp:193:  One space before end of line comments  [whitespace/comments] [5]
WebKit/chromium/src/gtk/WebInputEventFactory.cpp:194:  One space before end of line comments  [whitespace/comments] [5]
WebKit/chromium/src/gtk/WebInputEventFactory.cpp:195:  One space before end of line comments  [whitespace/comments] [5]
WebKit/chromium/src/gtk/WebInputEventFactory.cpp:196:  One space before end of line comments  [whitespace/comments] [5]
WebKit/chromium/src/gtk/WebInputEventFactory.cpp:197:  One space before end of line comments  [whitespace/comments] [5]
WebKit/chromium/src/gtk/WebInputEventFactory.cpp:198:  One space before end of line comments  [whitespace/comments] [5]
WebKit/chromium/src/gtk/WebInputEventFactory.cpp:199:  One space before end of line comments  [whitespace/comments] [5]
WebKit/chromium/src/gtk/WebInputEventFactory.cpp:200:  One space before end of line comments  [whitespace/comments] [5]
WebKit/chromium/src/gtk/WebInputEventFactory.cpp:201:  One space before end of line comments  [whitespace/comments] [5]
WebKit/chromium/src/gtk/WebInputEventFactory.cpp:202:  One space before end of line comments  [whitespace/comments] [5]
WebKit/chromium/src/gtk/WebInputEventFactory.cpp:203:  One space before end of line comments  [whitespace/comments] [5]
WebKit/chromium/src/gtk/WebInputEventFactory.cpp:204:  One space before end of line comments  [whitespace/comments] [5]
WebKit/chromium/src/gtk/WebInputEventFactory.cpp:205:  One space before end of line comments  [whitespace/comments] [5]
WebKit/chromium/src/gtk/WebInputEventFactory.cpp:206:  One space before end of line comments  [whitespace/comments] [5]
WebKit/chromium/src/gtk/WebInputEventFactory.cpp:207:  One space before end of line comments  [whitespace/comments] [5]
Total errors found: 54 in 4 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 3 Jay Civelli 2010-05-26 13:55:49 PDT
I believe the style of the CL is OK.
It is complaining that there is more than 1 space before the // comment, but I am just being consistent with the file style (aligning all // comments).
Comment 4 WebKit Commit Bot 2010-06-04 11:49:02 PDT
Comment on attachment 57116 [details]
First version of patch

Clearing flags on attachment: 57116

Committed r60692: <http://trac.webkit.org/changeset/60692>
Comment 5 WebKit Commit Bot 2010-06-04 11:49:08 PDT
All reviewed patches have been landed.  Closing bug.