Bug 3971

Summary: JS test suite depends on JS 1.2 behavior
Product: WebKit Reporter: Geoffrey Garen <ggaren>
Component: JavaScriptCoreAssignee: Geoffrey Garen <ggaren>
Status: RESOLVED FIXED    
Severity: Normal    
Priority: P2    
Version: 412   
Hardware: Mac   
OS: OS X 10.4   
Attachments:
Description Flags
Patch
darin: review-
Patch darin: review+

Geoffrey Garen
Reported 2005-07-12 16:32:47 PDT
The JS test suite attempts to use version() to travel back to the days of JS 1.2 and test for behaviors that are directly contradictory to the ECMA3 spec. Since we only support JS 1.5/ECMA3, and since version() is only a dummy function in our code, some tests raise false positives. Test failures: js1_2/Array/tostring_1.js js1_2/Array/tostring_2.js
Attachments
Patch (2.32 KB, patch)
2005-07-12 16:34 PDT, Geoffrey Garen 		darin: review-
DetailsFormatted DiffDiff
Patch (2.63 KB, patch)
2005-07-18 11:38 PDT, Geoffrey Garen 		darin: review+
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Geoffrey Garen
Comment 1 2005-07-12 16:34:04 PDT
Created attachment 2935 [details] Patch This patch makes the tests expect JS 1.5 results.
Darin Adler
Comment 2 2005-07-18 07:54:16 PDT
Comment on attachment 2935 [details] Patch I'd like the change to the tests to at least document what's going on rather than simply commenting out the code. When we get new versions of the JS test suite, we may need to merge this change in, and it would be good to make sure it's "self-documenting". I must admit I don't entirely understand why removing this code completely is the best fix, but I think a comment explaining why would probably convince me.
Geoffrey Garen
Comment 3 2005-07-18 11:38:09 PDT
Created attachment 2991 [details] Patch Updated patch to include comment.
Note You need to log in before you can comment on or make changes to this bug.