Bug 39690
| Summary: | check-webkit-style incorrect if patch is only deletes | ||
|---|---|---|---|
| Product: | WebKit | Reporter: | Ojan Vafai <ojan> |
| Component: | Tools / Tests | Assignee: | Nobody <webkit-unassigned> |
| Status: | RESOLVED DUPLICATE | ||
| Severity: | Normal | CC: | cjerdonek, eric |
| Priority: | P2 | ||
| Version: | 528+ (Nightly build) | ||
| Hardware: | PC | ||
| OS: | OS X 10.5 | ||
Ojan Vafai
Make a patch with only deletes and run check-webkit-style.
I get this output
$ check-webkit-style --git-commit head --verbose
webkitpy.common.system.logutils: DEBUG Debug logging enabled.
check-webkit-style: DEBUG Verbose logging enabled.
webkitpy.common.system: DEBUG "git rev-parse --is-inside-work-tree" took 0.01s
webkitpy.common.system: DEBUG "git rev-parse --git-dir" took 0.01s
check-webkit-style: DEBUG WebKit checkout found with root: /WebKit/
webkitpy.style.main: DEBUG Changing to checkout root: /WebKit/
webkitpy.common.system: DEBUG "git diff --binary --no-ext-diff --full-index -M head^..head" took 0.02s
webkitpy.style.patchreader: DEBUG Found 0 new or modified lines in: WebKitTools/Scripts/webkitpy/common/net/rietveld.py
check-webkit-style: INFO Total errors found: 0 in 0 files
The bug is in patchreader.py. It only checks style on files that have modified/new lines. That part makes sense. But since it doesn't call process_file, the test_file_reader thinks that no files were checked.
This means that check-webkit-style errors out and webkit-patch upload prompts whether to continue.
| Attachments | ||
|---|---|---|
| Add attachment proposed patch, testcase, etc. |
Chris Jerdonek
*** This bug has been marked as a duplicate of bug 38169 ***