Bug 39648

Summary: [EFL] build error: need to use namespace and add more parameter when creating a Page object
Product: WebKit Reporter: Joone Hur <joone.hur>
Component: WebKit WebsiteAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Critical CC: abarth, commit-queue, eric, hyuki.kim, joone, leandro, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: PC   
OS: Linux   
Attachments:
Description Flags
Patch none

Description Joone Hur 2010-05-24 23:30:03 PDT 
When using FrameView in efl/ewk/ewk_frame.cpp, WebCore namespace is missed.
When creating a Page, DeviceOrientationClient parameter is missed.
Comment 1 Joone Hur 2010-05-24 23:46:55 PDT 
Created attachment 56980 [details]
Patch
Comment 2 Leandro Pereira 2010-05-25 04:07:46 PDT 
Looks good to me.
Comment 3 WebKit Commit Bot 2010-05-25 14:12:10 PDT 
Comment on attachment 56980 [details]
Patch

Clearing flags on attachment: 56980

Committed r60182: <http://trac.webkit.org/changeset/60182>
Comment 4 WebKit Commit Bot 2010-05-25 14:12:15 PDT 
All reviewed patches have been landed.  Closing bug.
Comment 5 WebKit Review Bot 2010-05-25 14:55:09 PDT 
http://trac.webkit.org/changeset/60182 might have broken GTK Linux 64-bit Release
The following changes are on the blame list:
http://trac.webkit.org/changeset/60184
http://trac.webkit.org/changeset/60182
http://trac.webkit.org/changeset/60183