Bug 39643

Summary: Clean up code generation in the JIT of stub function calls for op_call.
Product: WebKit Reporter: Gavin Barraclough <barraclough>
Component: JavaScriptCoreAssignee: Gavin Barraclough <barraclough>
Status: RESOLVED FIXED    
Severity: Normal    
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: PC   
OS: OS X 10.5   
Attachments:
Description Flags
The patch sam: review+

Gavin Barraclough
Reported 2010-05-24 20:27:26 PDT
Presently, as soon as op-call strays of the hot path we set up a set of values on the stack to be passed as arguments to cti functions, in case any should be called. Instead, hoist the setup of the callframe to happen slightly sooner, and make the cti functions to compile & check arity read these values from the callframe. This allows up to remove the deprecated methods to manually set up cti arguments, rather than using JITStubCall.h.
Attachments
The patch (45.37 KB, patch)
2010-05-24 20:28 PDT, Gavin Barraclough 		sam: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Gavin Barraclough
Comment 1 2010-05-24 20:28:49 PDT
Created attachment 56967 [details] The patch
Gavin Barraclough
Comment 2 2010-05-24 21:33:04 PDT
Transmitting file data .......... Committed revision 60125.
Note You need to log in before you can comment on or make changes to this bug.