|Summary:||webkit-patch land calls scm.changed_files 4 times!|
|Product:||WebKit||Reporter:||Eric Seidel (no email) <eric>|
|Component:||Tools / Tests||Assignee:||Nobody <webkit-unassigned>|
|Severity:||Normal||CC:||abarth, cjerdonek, commit-queue, mjs, ojan|
|Version:||528+ (Nightly build)|
|OS:||OS X 10.5|
Description Eric Seidel (no email) 2010-05-24 01:31:53 PDT
Comment 1 Eric Seidel (no email) 2010-05-24 01:34:10 PDT
Actually, it's scm.changed_files() at fault here.
Comment 2 Eric Seidel (no email) 2010-05-24 01:55:04 PDT
Ok, so 3 of those were scm.changed_files, and one of those was scm.working_directory_is_clean. I have a patch to get rid of two of the changed_files calls. Not sure about the scm.working_directory_is_clean call yet.
Comment 3 Eric Seidel (no email) 2010-05-24 02:00:25 PDT
Created attachment 56862 [details] Patch
Comment 4 Adam Barth 2010-05-24 02:22:40 PDT
Comment on attachment 56862 [details] Patch Ok.
Comment 5 WebKit Commit Bot 2010-05-24 21:28:27 PDT
Comment on attachment 56862 [details] Patch Clearing flags on attachment: 56862 Committed r60124: <http://trac.webkit.org/changeset/60124>
Comment 6 WebKit Commit Bot 2010-05-24 21:28:36 PDT
All reviewed patches have been landed. Closing bug.