Bug 39572

Summary:

Add new HTML5TreeBuilder class to hold the tree builder section of the HTML5 parsing spec

Product:

WebKit

Reporter:

Eric Seidel (no email) <eric>

Component:

New Bugs

Assignee:

Eric Seidel (no email) <eric>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

abarth, commit-queue, eric, webkit.review.bot

Priority:

Version:

528+ (Nightly build)

Hardware:

Other

OS:

OS X 10.5

Attachments:

Description	Flags
Patch	none
Patch for landing	none
Patch for landing	commit-queue: commit-queue-
Patch for landing	none

Eric Seidel (no email)

Reported 2010-05-23 15:17:08 PDT

Add new HTML5TreeBuilder class to hold the tree builder section of the HTML5 parsing spec

Attachments
Patch (16.57 KB, patch) 2010-05-23 15:27 PDT, Eric Seidel (no email)	no flags	Details Formatted Diff Diff
Patch for landing (17.16 KB, patch) 2010-05-23 15:53 PDT, Eric Seidel (no email)	no flags	Details Formatted Diff Diff
Patch for landing (17.15 KB, patch) 2010-05-23 16:40 PDT, Eric Seidel (no email)	commit-queue: commit-queue-	Details Formatted Diff Diff
Patch for landing (17.58 KB, patch) 2010-05-23 17:47 PDT, Eric Seidel (no email)	no flags	Details Formatted Diff Diff
Show Obsolete (3) View All Add attachment proposed patch, testcase, etc.

Eric Seidel (no email)

Comment 1 2010-05-23 15:27:01 PDT

Created attachment 56833 [details] Patch

Adam Barth

Comment 2 2010-05-23 15:30:25 PDT

Comment on attachment 56833 [details] Patch WebCore/html/HTML5Tokenizer.cpp:40 + , m_parser(new HTML5TreeBuilder(doc, reportErrors)) Should we change the name of this member variable? WebCore/html/HTML5TreeBuilder.cpp:37 + One space in C++ land WebCore/html/HTML5TreeBuilder.cpp:82 + // FIXME: This work is supposed to be done by the parser, but This code is now in the right file, so maybe update the comment?

Eric Seidel (no email)

Comment 3 2010-05-23 15:37:21 PDT

Done, done and Done. Will merge and land shortly.

Eric Seidel (no email)

Comment 4 2010-05-23 15:53:25 PDT

Created attachment 56835 [details] Patch for landing

Eric Seidel (no email)

Comment 5 2010-05-23 16:40:34 PDT

Created attachment 56837 [details] Patch for landing

Eric Seidel (no email)

Comment 6 2010-05-23 17:47:03 PDT

Created attachment 56838 [details] Patch for landing

WebKit Commit Bot

Comment 7 2010-05-23 18:06:03 PDT

Comment on attachment 56837 [details] Patch for landing Rejecting patch 56837 from commit-queue. Failed to run "['WebKitTools/Scripts/build-webkit', '--debug']" exit_code: 1 Last 500 characters of output: setenv YACC /Developer/usr/bin/yacc /bin/sh -c /Users/eseidel/Projects/CommitQueue/WebKitBuild/WebCore.build/Debug/WebCore.build/Script-5DF50887116F3077005202AB.sh ** BUILD FAILED ** The following build commands failed: WebCore: Distributed-CompileC /Users/eseidel/Projects/CommitQueue/WebKitBuild/WebCore.build/Debug/WebCore.build/Objects-normal/i386/HTML5Tokenizer.o /Users/eseidel/Projects/CommitQueue/WebCore/html/HTML5Tokenizer.cpp normal i386 c++ com.apple.compilers.gcc.4_2 (1 failure) Full output: http://webkit-commit-queue.appspot.com/results/2356098

WebKit Commit Bot

Comment 8 2010-05-23 18:21:00 PDT

Comment on attachment 56838 [details] Patch for landing Clearing flags on attachment: 56838 Committed r60055: <http://trac.webkit.org/changeset/60055>

WebKit Commit Bot

Comment 9 2010-05-23 18:21:05 PDT

All reviewed patches have been landed. Closing bug.

WebKit Review Bot

Comment 10 2010-05-23 18:27:18 PDT

http://trac.webkit.org/changeset/60055 might have broken Qt Linux Release minimal and Chromium Linux Release

Eric Seidel (no email)

Comment 11 2010-05-23 18:30:16 PDT

Preparing buildfix now.

Eric Seidel (no email)

Comment 12 2010-05-23 18:38:33 PDT

Committed r60056: <http://trac.webkit.org/changeset/60056>

Note You need to log in before you can comment on or make changes to this bug.