Bug 3953

Summary: back-forward items have wrong titles after sub-frame navigations
Product: WebKit Reporter: Trey Matteson <trey>
Component: FramesAssignee: Trey Matteson <trey>
Status: RESOLVED FIXED    
Severity: Normal    
Priority: P2    
Version: 412   
Hardware: Mac   
OS: OS X 10.4   
URL: http://java.sun.com/j2se/1.5.0/docs/api/index.html
Attachments:
Description Flags
patch for bug 3953 sullivan: review+

Description Trey Matteson 2005-07-11 12:03:36 PDT
Goto http://java.sun.com/j2se/1.5.0/docs/api/index.html.  Note the title is "Overview...".  Now click 
some class names in the lower left pane.  Press and hold the back button.  The oldest item that should 
still be "Overview..." is now titled the same as the last class page that was loaded.

At the HTML level, what's happening is that whenever a frame loads it sets the parent.document.title to 
be specific to that newly loaded frame.

The same is also true for the history item for the overview page - its title also changes as the page 
changes its title dynamically.  I don't think this is very desirable behavior from the user perspective, but 
given the page keeps changing it's title, it's not as clear to me that this is technically incorrect.
Comment 1 Trey Matteson 2005-07-11 12:46:51 PDT
I checked WinIE, and they do not allow the title of the history item to change due to subsequent loads, 
**while the window is open **.  When you open a new window and look at history, then the item has the 
newly requested title.  So perhaps they let the items title change, but just don't have any way to track that 
change dynamically in their history UI.
Comment 2 Trey Matteson 2005-07-11 16:52:02 PDT
Created attachment 2912 [details]
patch for bug 3953
Comment 3 John Sullivan 2005-07-11 17:25:53 PDT
Comment on attachment 2912 [details]
patch for bug 3953

Looks very good to me (bug fix plus code simplfication, yay!). Whoever commits
this should verify that it fixes the specific bug reported here (the oldest
title in the Back button's menu should be Overview after the fix).
Comment 4 Justin Garcia 2005-07-24 16:15:29 PDT
Landed this patch, and verified fix.