Bug 39509

Summary: Exceptions raised when JSString::value() is called not always properly thrown.
Product: WebKit Reporter: Gavin Barraclough <barraclough>
Component: JavaScriptCoreAssignee: Gavin Barraclough <barraclough>
Status: RESOLVED FIXED    
Severity: Normal CC: zherczeg
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: PC   
OS: OS X 10.5   
Attachments:
Description Flags
The patch
none
Fix to tryGetValue() oliver: review+

Gavin Barraclough
Reported 2010-05-21 12:48:35 PDT
Missing some CHECK_FOR_EXCEPTION()s.
Attachments
The patch (20.15 KB, patch)
2010-05-21 13:53 PDT, Gavin Barraclough 		no flags
DetailsFormatted DiffDiff
Fix to tryGetValue() (20.89 KB, patch)
2010-05-21 15:14 PDT, Gavin Barraclough 		oliver: review+
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Gavin Barraclough
Comment 1 2010-05-21 13:53:56 PDT
Created attachment 56742 [details] The patch
Alexey Proskuryakov
Comment 2 2010-05-21 14:42:47 PDT
Is this <rdar://problem/8005199>?
Gavin Barraclough
Comment 3 2010-05-21 14:43:23 PDT
(In reply to comment #2) > Is this <rdar://problem/8005199>? Yep
Gavin Barraclough
Comment 4 2010-05-21 15:14:31 PDT
Created attachment 56751 [details] Fix to tryGetValue()
Oliver Hunt
Comment 5 2010-05-21 15:27:16 PDT
Comment on attachment 56751 [details] Fix to tryGetValue() r=me
Zoltan Herczeg
Comment 6 2010-05-21 15:30:48 PDT
In NativeErrorConstructor.cpp:46 the extra line was accidentally inserted isn't it? Otherwise, this is a good patch. And nice catch.
Gavin Barraclough
Comment 7 2010-05-21 16:50:03 PDT
Transmitting file data ............... Committed revision 59974.
Zoltan Herczeg
Comment 8 2010-05-21 21:40:42 PDT
http://trac.webkit.org/changeset/59974 The SVN message of the fix is strange, but the patch is ok. It sasy: Unreviewed build fix. Patch by David Levin < levin@chromium.org> on 2010-05-21 * wtf/SizeLimits.cpp: Removed a check while I figure out how to write it properly. Is it happened with trac.webkit.org? Or something wrong in my machine?
Note You need to log in before you can comment on or make changes to this bug.