|Summary:||Fix MIPS JIT DoubleGreaterThanOrEqual Operands|
|Product:||WebKit||Reporter:||Chao-ying Fu <fu>|
|Version:||528+ (Nightly build)|
Description Chao-ying Fu 2010-05-21 11:35:34 PDT
There is a typo in MIPS JIT for DoubleGreaterThanOrEqual. Two operands of left and right need to be swapped. Thanks!
Comment 1 Chao-ying Fu 2010-05-21 11:41:28 PDT
Created attachment 56733 [details] Swapped two operands Here is the patch
Comment 2 Eric Seidel (no email) 2010-05-21 11:59:59 PDT
Comment on attachment 56733 [details] Swapped two operands Please fix the ChangeLog to mention which test this fixes. If it does not fix a test, please add one.
Comment 3 Chao-ying Fu 2010-05-21 13:07:38 PDT
Created attachment 56739 [details] Updated ChangeLog This patch fixed two layout tests as follows. fast/js/comparison-operators-greater.html fast/js/comparison-operators-less.html The ChangeLog is updated to mention these two patches. Thanks! Regards, Chao-ying
Comment 4 Chao-ying Fu 2010-05-21 17:52:35 PDT
Note that the two layout tests failed on MIPS after tests are added recently, I spent some time debugging them and found out that the operands are swapped incorrectly in MIPS JIT for c.nge.d instructions. Thanks!
Comment 5 Eric Seidel (no email) 2010-05-28 16:02:47 PDT
Comment on attachment 56739 [details] Updated ChangeLog Thank you for updating the ChagneLog. Fantastic patch now that I can clearly see what it fixes from the ChangeLog.
Comment 6 WebKit Commit Bot 2010-05-28 19:54:31 PDT
Comment on attachment 56739 [details] Updated ChangeLog Clearing flags on attachment: 56739 Committed r60383: <http://trac.webkit.org/changeset/60383>
Comment 7 WebKit Commit Bot 2010-05-28 19:54:36 PDT
All reviewed patches have been landed. Closing bug.