Bug 39483 – Building Efl port fails

• Component: WebKit Misc.
• Status: RESOLVED FIXED

[Jos van den Oever]

Created attachment 56700 [details]
fix efl build

The Efl port has not been maintained for a while and the CMake files are a bit stale. The attached patch fixes this.

[Adam Roben (:aroben)]

Comment on attachment 56700 [details]
fix efl build

> @@ -76,7 +76,7 @@ SET(WebKit_LIBRARY_TYPE SHARED)
>  # Port-specific options
>  # -----------------------------------------------------------------------------
>  INCLUDE(OptionsCommon)
> -INCLUDE(Options${PORT})
> +INCLUDE(Options${PORT} OPTIONAL)

I didn't see any explanation of this change in your commit message.

The WebKit project uses ChangeLog files as well as commit messages to explain changes. You can use the prepare-ChangeLog script to add a skeleton ChangeLog entry to the appropriate file, and then you can edit the entry manually. We then use the ChangeLog entry as the commit message.

If you add a ChangeLog entry and explain the above change, I think we can get this landed.

[Jos van den Oever]

Created attachment 56703 [details]
fix efl build

[Darin Adler]

Comment on attachment 56703 [details]
fix efl build

Thanks for working on this. The ChangeLog still needs a bit of work.

> +        Need a short description and bug URL (OOPS!)

You need to replace this with the bug URL.

> +        Reviewed by NOBODY (OOPS!).

This you don't need to fill in until after reviewing, and the person landing it will take care of it.

> +        No new tests. (OOPS!)

This line you need to delete.

The only OOPS that should be left in the ChangeLog int he patch you upload should be in the "Reviewed by" line.

[Lucas De Marchi]

(In reply to comment #0)
> Created an attachment (id=56700) [details]
> fix efl build
> 
> The Efl port has not been maintained for a while and the CMake files are a bit stale. The attached patch fixes this.

Not that it's not maintained. It's actively maintained and developed. One of the problems is that we don't have a build bot yet, so any changes inside webkit that is not properly updated in our CMake files may break it.

Meanwhile, we are continually sending patches to fix building problems, that unfortunately take a while to be applied. You can search by EFL and/or profusion.mobi to see our updates.

[Lucas De Marchi]

Mind closing this bug now that it builds?

[Jos van den Oever]

This has been fixed in the meantime.