Bug 39477

Summary: Make spotlight work like the W3-expected
Product: WebKit Reporter: Zoltan Herczeg <zherczeg>
Component: SVGAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: krit, zimmermann
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: All   
OS: All   
URL: http://dev.w3.org/SVG/profiles/1.1F2/test/harness/htmlObject/filters-light-04-f.html
Attachments:
Description Flags
proposed fix
none
proposed fix
none
patch without filters-light-01-f-expected.png krit: review+

Zoltan Herczeg
Reported 2010-05-21 02:38:58 PDT
Much is missing from the speficiation (SVG standard), like the definition of spot-light cone anti-aliasing. My first idea was similar as how FireFox works (based on the hints in the specification), but it was neither looked good, nor matched for the expected values. Finding more expected values, I did some reverse engineering, and now I can mimic the SVG expected values.
Attachments
proposed fix (58.59 KB, patch)
2010-05-21 02:52 PDT, Zoltan Herczeg 		no flags
DetailsFormatted DiffDiff
proposed fix (92.36 KB, patch)
2010-05-21 02:56 PDT, Zoltan Herczeg 		no flags
DetailsFormatted DiffDiff
patch without filters-light-01-f-expected.png (62.57 KB, patch)
2010-05-21 04:06 PDT, Zoltan Herczeg 		krit: review+
DetailsFormatted DiffDiff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.
Zoltan Herczeg
Comment 1 2010-05-21 02:52:50 PDT
Created attachment 56688 [details] proposed fix
Zoltan Herczeg
Comment 2 2010-05-21 02:56:19 PDT
Created attachment 56689 [details] proposed fix
Zoltan Herczeg
Comment 3 2010-05-21 04:06:40 PDT
Created attachment 56694 [details] patch without filters-light-01-f-expected.png svn-apply does not yet support git binray delta diffs. I removed the filters-light-01-f-expected.png, to allow to run the bots.
Dirk Schulze
Comment 4 2010-05-31 13:06:36 PDT
Comment on attachment 56694 [details] patch without filters-light-01-f-expected.png r+ to get the W3C expected results.
Zoltan Herczeg
Comment 5 2010-06-01 01:12:34 PDT
Patch landed in r60466: http://trac.webkit.org/changeset/60466 As we discussed I sent questions about the anti-alias of the cone to the www-svg mailing list, but no reply so far.
Note You need to log in before you can comment on or make changes to this bug.