Bug 39463

Summary: Avoid flushing CA layers when a layout is pending
Product: WebKit Reporter: Simon Fraser (smfr) <simon.fraser>
Component: Layout and RenderingAssignee: Simon Fraser (smfr) <simon.fraser>
Status: RESOLVED FIXED    
Severity: Normal CC: aroben, cmarrin
Priority: P2 Keywords: InRadar
Version: 528+ (Nightly build)   
Hardware: PC   
OS: OS X 10.5   
Attachments:
Description Flags
Patch aroben: review+

Simon Fraser (smfr)
Reported 2010-05-20 18:06:41 PDT
On Mac we avoid displaying CA layers when a layout is pending, since the layers may be stale. We should do the same on Windows.
Attachments
Patch (7.67 KB, patch)
2010-05-20 18:44 PDT, Simon Fraser (smfr) 		aroben: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Simon Fraser (smfr)
Comment 1 2010-05-20 18:44:14 PDT
Created attachment 56657 [details] Patch
Simon Fraser (smfr)
Comment 2 2010-05-20 18:45:40 PDT
<rdar://problem/7999463>
Adam Roben (:aroben)
Comment 3 2010-05-20 18:49:01 PDT
Comment on attachment 56657 [details] Patch > +bool WebView::shouldRender() const > +{ > + Frame* coreFrame = core(m_mainFrame); > + if (!coreFrame) > + return true; > + FrameView* frameView = coreFrame->view(); > + if (frameView) > + return !frameView->layoutPending(); > + > + return true; > +} I think reversing the last condition would be clearer. r=me
Simon Fraser (smfr)
Comment 4 2010-05-20 21:49:51 PDT
http://trac.webkit.org/changeset/59910
Note You need to log in before you can comment on or make changes to this bug.