Bug 3942

Summary: REGRESSION (412+): Incorrect height of MARQUEE when specified as HTML attribute
Product: WebKit Reporter: mitz
Component: Layout and RenderingAssignee: Beth Dakin <bdakin>
Status: VERIFIED FIXED    
Severity: Normal    
Priority: P1    
Version: 420+   
Hardware: Mac   
OS: OS X 10.4   
Attachments:
Description Flags
Testcase none

mitz
Reported 2005-07-10 07:57:25 PDT
A MARQUEE whose height is specified using the HEIGHT attribute (rather than as a CSS property) ends up having a different height (that seems to depend on the height of its contents). In the attached testcase, the expected result is two marquees 100px tall and a green rect 100px tall. The actual result is that the yellow marquee's height is almost 400px instead.
Attachments
Testcase (1.47 KB, text/html)
2005-07-10 07:58 PDT, mitz 		no flags
Details
View All Add attachment proposed patch, testcase, etc.
mitz
Comment 1 2005-07-10 07:58:27 PDT
Created attachment 2900 [details] Testcase
Chris Petersen
Comment 2 2005-07-10 10:14:15 PDT
Confirming this issue with a fresh pull of TOT Webkit (07/10). This problem doesn't occur in Safari 2.0 (412) and Mac Firefox 1.0.4.
Beth Dakin
Comment 3 2005-07-12 14:14:23 PDT
I checked in a fix for this problem. I added a small section to updateMarqueeStyle() in render_layer.cpp that address this problem and the original problem that caused this regression. Vertical marquees without a specified height attribute will now default to 200px.
mitz
Comment 4 2005-07-12 16:04:20 PDT
Thanks, Beth!
Note You need to log in before you can comment on or make changes to this bug.