Bug 3936

Summary: Remove Bison 2.0 requirement from kdom
Product: WebKit Reporter: Eric Seidel (no email) <eric>
Component: SVGAssignee: Eric Seidel (no email) <eric>
Status: RESOLVED FIXED    
Severity: Normal    
Priority: P4    
Version: 420+   
Hardware: Mac   
OS: OS X 10.4   
Attachments:
Description Flags
A patch to get kdomparsecss.y to work with bison v1.28
darin: review+
Fixes both kdomparsecss.y and xpath.ypp to work with bison v1.28 eric: review+

Eric Seidel (no email)
Reported 2005-07-10 01:26:03 PDT
Remove Bison 2.0 requirement from kdom The current kdomcssparser.y and xpath.ypp do not process correctly under Bison 1.28 (which ships with Mac OS X Tiger), thus building WebCore+SVG requires Bison 2.x. It would be great to get rid of this restriction.
Attachments
A patch to get kdomparsecss.y to work with bison v1.28 (959 bytes, patch)
2005-07-26 22:08 PDT, Ben La Monica 		darin: review+
DetailsFormatted DiffDiff
Fixes both kdomparsecss.y and xpath.ypp to work with bison v1.28 (2.22 KB, patch)
2005-07-27 20:26 PDT, Ben La Monica 		eric: review+
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Ben La Monica
Comment 1 2005-07-26 22:08:05 PDT
Created attachment 3105 [details] A patch to get kdomparsecss.y to work with bison v1.28 Removed the %%destructor and %%verbose statements for the time being. It would be a good idea to use bison-2.0, as the %%destructor will prevent memory leaks when a parse error occurs.
Darin Adler
Comment 2 2005-07-27 10:28:43 PDT
Comment on attachment 3105 [details] A patch to get kdomparsecss.y to work with bison v1.28 Loooks fine to land for now.
Ben La Monica
Comment 3 2005-07-27 20:26:34 PDT
Created attachment 3130 [details] Fixes both kdomparsecss.y and xpath.ypp to work with bison v1.28 This patch fixes both bison files so that they will generate the parsers with bison version 1.28. It would probably be a good idea to eventually migrate to bison 2.0 since it offers new features that reduce memory leaks.
Note You need to log in before you can comment on or make changes to this bug.