Bug 3936

Summary:

Remove Bison 2.0 requirement from kdom

Product:

WebKit

Reporter:

Eric Seidel (no email) <eric>

Component:

SVG

Assignee:

Eric Seidel (no email) <eric>

Status:

RESOLVED FIXED

Severity:

Normal

Priority:

Version:

420+

Hardware:

Mac

OS:

OS X 10.4

Attachments:

Description	Flags
A patch to get kdomparsecss.y to work with bison v1.28	darin: review+
Fixes both kdomparsecss.y and xpath.ypp to work with bison v1.28	eric: review+

Description Eric Seidel (no email) 2005-07-10 01:26:03 PDT

Remove Bison 2.0 requirement from kdom

The current kdomcssparser.y and xpath.ypp do not process correctly under Bison 1.28 (which ships with 
Mac OS X Tiger), thus building WebCore+SVG requires Bison 2.x.  It would be great to get rid of this 
restriction.

Comment 1 Ben La Monica 2005-07-26 22:08:05 PDT

Created attachment 3105 [details]
A patch to get kdomparsecss.y to work with bison v1.28

Removed the %%destructor and %%verbose statements for the time being.

It would be a good idea to use bison-2.0, as the %%destructor will prevent
memory leaks when a parse error occurs.

Comment 2 Darin Adler 2005-07-27 10:28:43 PDT

Comment on attachment 3105 [details]
A patch to get kdomparsecss.y to work with bison v1.28

Loooks fine to land for now.

Comment 3 Ben La Monica 2005-07-27 20:26:34 PDT

Created attachment 3130 [details]
Fixes both kdomparsecss.y and xpath.ypp to work with bison v1.28

This patch fixes both bison files so that they will generate the parsers with
bison version 1.28.

It would probably be a good idea to eventually migrate to bison 2.0 since it
offers new features that reduce memory leaks.