Bug 39343

Summary: Dynamically generate a native call trunk per NativeFunction
Product: WebKit Reporter: Gavin Barraclough <barraclough>
Component: JavaScriptCoreAssignee: Gavin Barraclough <barraclough>
Status: RESOLVED FIXED    
Severity: Normal CC: webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: PC   
OS: OS X 10.5   
Attachments:
Description Flags
The patch
none
Ooops! revert change to Platform.h! ggaren: review+

Gavin Barraclough
Reported 2010-05-18 22:51:49 PDT
https://bugs.webkit.org/show_bug.cgi?id=39252 regressed performance on i386, by adding an extra indirection to making a native call. By introducing per-NativeFunction thunks we can hard code the function pointer into the thunk so that it need not be loaded from the callee.
Attachments
The patch (27.48 KB, patch)
2010-05-18 22:52 PDT, Gavin Barraclough 		no flags
DetailsFormatted DiffDiff
Ooops! revert change to Platform.h! (27.08 KB, patch)
2010-05-18 22:54 PDT, Gavin Barraclough 		ggaren: review+
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Gavin Barraclough
Comment 1 2010-05-18 22:52:52 PDT
Created attachment 56456 [details] The patch
Gavin Barraclough
Comment 2 2010-05-18 22:54:36 PDT
Created attachment 56458 [details] Ooops! revert change to Platform.h!
Geoffrey Garen
Comment 3 2010-05-18 22:57:50 PDT
Comment on attachment 56458 [details] Ooops! revert change to Platform.h! r=me
WebKit Review Bot
Comment 4 2010-05-18 22:58:20 PDT
Attachment 56458 [details] did not pass style-queue: Failed to run "['WebKitTools/Scripts/check-webkit-style', '--no-squash']" exit_code: 1 JavaScriptCore/jit/JITOpcodes32_64.cpp:613: Tests for true/false, null/non-null, and zero/non-zero should all be done without equality comparisons. [readability/comparison_to_zero] [5] Total errors found: 1 in 15 files If any of these errors are false positives, please file a bug against check-webkit-style.
Gavin Barraclough
Comment 5 2010-05-18 23:04:43 PDT
Transmitting file data ............... Committed revision 59746.
Note You need to log in before you can comment on or make changes to this bug.