Summary: | Tests with Snow Leopard-specific pixel expected results in platform/mac need platform/mac-leopard expectations | ||||||||
---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | James Robinson <jamesr> | ||||||
Component: | Tools / Tests | Assignee: | Nobody <webkit-unassigned> | ||||||
Status: | RESOLVED WONTFIX | ||||||||
Severity: | Normal | CC: | bfulgham, dpranke | ||||||
Priority: | P2 | ||||||||
Version: | 528+ (Nightly build) | ||||||||
Hardware: | PC | ||||||||
OS: | OS X 10.5 | ||||||||
Attachments: |
|
Description
James Robinson
2010-05-18 15:32:27 PDT
It looks like the following tests fall into this category: compositing/color-matching/pdf-image-match.html compositing/reflections/simple-composited-reflections.html compositing/repaint/overflow-into-content.html editing/pasteboard/drag-image-to-contenteditable-in-iframe.html fast/css/pseudo-cache-stale.html fast/frames/take-focus-from-iframe.html fast/repaint/fixed-child-move-after-scroll.html fast/repaint/fixed-child-of-fixed-move-after-scroll.html fast/repaint/fixed-child-of-transformed-move-after-scroll.html fast/repaint/fixed-move-after-scroll.html fast/text/format-control.html plugins/qt-qwidget-plugin.html transforms/svg-vs-css.xhtml transitions/move-after-transition.html Created attachment 56433 [details]
Patch
Committed r59723: <http://trac.webkit.org/changeset/59723> That patch took care of everything that passed exactly on Snow Leopard and failed with a diff <= 0.01% on Leopard. Next up, the tests that pass exactly on Snow Leopard and failed with a diff <= 0.1% on Leopard... Next hitlist (exact pass on SL, <0.1% diff on Leopard): compositing/geometry/horizontal-scroll-composited.html compositing/geometry/transfrom-origin-on-zero-size-layer.html compositing/geometry/vertical-scroll-composited.html compositing/masks/direct-image-mask.html compositing/reflections/reflection-in-composited.html fast/forms/placeholder-stripped.html media/video-replaces-poster.html compositing/repaint/opacity-between-absolute.html compositing/repaint/opacity-between-absolute2.html compositing/iframes/iframe-copy-on-scroll.html fast/borders/svg-as-border-image.html media/controls-strict.html media/video-display-toggle.html animations/3d/change-transform-in-end-event.html compositing/animation/state-at-end-event-transform-layer.html compositing/compositing-visible-descendant.html compositing/geometry/abs-position-inside-opacity.html compositing/geometry/fixed-position.html compositing/geometry/partial-layout-update.html compositing/reflections/reflection-ordering.html compositing/repaint/layer-repaint.html compositing/overflow/fixed-position-ancestor-clip.html compositing/repaint/content-into-overflow.html fast/borders/svg-as-border-image-2.html Created attachment 56439 [details]
Patch
Committed r59730: <http://trac.webkit.org/changeset/59730> OK, now all tests that pass with --tolerance=0 on Snow Leopard either pass with --tolerance=0 on Leopard or have image diffs >0.1%. The ones with larger differences need more careful analysis. Next (and hopefully final) batch: The following tests pass on Snow Leopard but fail on Leopard due to small changes in text rendering, form control drawing, or due to gamma adjustments not propagating into the media and webgl layers. Thus, I plan to rebaseline them: compositing/geometry/clipping-foreground.html compositing/geometry/composited-html-size.html compositing/geometry/fixed-in-composited.html compositing/images/direct-image-background-color.html compositing/overflow/ancestor-overflow.html compositing/overflow/overflow-scroll.html compositing/reflections/compositing-change-inside-reflection.html compositing/reflections/reflection-opacity.html compositing/shadows/shadow-drawing.html compositing/transitions/scale-transition-no-start.html compositing/video/video-background-color.html compositing/webgl/webgl-background-color.html fast/block/float/float-avoidance.html media/video-aspect-ratio.html media/video-zoom.html We aren't targeting Leopard development systems anymore. |