Bug 39314

Summary: [Qt] Skipping popup focus test for maemo
Product: WebKit Reporter: Luiz Agostini <luiz>
Component: New BugsAssignee: Luiz Agostini <luiz>
Status: CLOSED FIXED    
Severity: Normal CC: commit-queue, hausmann
Priority: P3 Keywords: Qt
Version: 528+ (Nightly build)   
Hardware: All   
OS: All   
Attachments:
Description Flags
patch 1
none
patch 2 none

Luiz Agostini
Reported 2010-05-18 13:30:45 PDT
in tst_qwebframe the popup focus test is based on the usage of a QComboBox by QtWebKit to provide combo popups. As maemo does not use a QComboBox for that the test does not make sense for maemo.
Attachments
patch 1 (4.01 KB, patch)
2010-05-18 13:55 PDT, Luiz Agostini 		no flags
DetailsFormatted DiffDiff
patch 2 (4.72 KB, patch)
2010-05-18 14:55 PDT, Luiz Agostini 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Luiz Agostini
Comment 1 2010-05-18 13:55:47 PDT
Created attachment 56410 [details] patch 1
Luiz Agostini
Comment 2 2010-05-18 14:55:34 PDT
Created attachment 56415 [details] patch 2
Kenneth Rohde Christiansen
Comment 3 2010-05-18 14:58:01 PDT
Comment on attachment 56415 [details] patch 2 LGTM, please block the patch for qtwebkit2.0 branch integration/
WebKit Commit Bot
Comment 4 2010-05-20 06:44:07 PDT
Comment on attachment 56415 [details] patch 2 Clearing flags on attachment: 56415 Committed r59831: <http://trac.webkit.org/changeset/59831>
WebKit Commit Bot
Comment 5 2010-05-20 06:44:13 PDT
All reviewed patches have been landed. Closing bug.
Simon Hausmann
Comment 6 2010-05-20 08:11:53 PDT
Revision r59831 cherry-picked into qtwebkit-2.0 with commit d7f3d44c8e0cecdb945219ec5dfb289bcf9a803f
Note You need to log in before you can comment on or make changes to this bug.