Bug 39285

Summary: REGRESSION(59659): fast/files/file-reader.html is timing out on all mac bots
Product: WebKit Reporter: Eric Seidel (no email) <eric>
Component: Tools / TestsAssignee: Jian Li <jianli>
Status: RESOLVED FIXED    
Severity: Normal CC: dimich, hausmann, jianli
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: PC   
OS: OS X 10.5   
Attachments:
Description Flags
Proposed Patch
jianli: commit-queue-
Proposed Patch dimich: review+, jianli: commit-queue-

Eric Seidel (no email)
Reported 2010-05-18 04:51:00 PDT
REGRESSION(59660?): fast/files/file-reader.html is timing out on all mac bots The buildbot logs claim this to be a regression from r59660, but that seems impossible. http://trac.webkit.org/browser/trunk/LayoutTests/fast/files/file-reader.html This test has been flaky on some machines since it was checked in. I think the flake may have finally turned to a permanent failure for unknown reasons.
Attachments
Proposed Patch (8.40 KB, patch)
2010-05-18 12:42 PDT, Jian Li
jianli: commit-queue-
Proposed Patch (8.79 KB, patch)
2010-05-18 13:21 PDT, Jian Li
dimich: review+
jianli: commit-queue-
Eric Seidel (no email)
Comment 1 2010-05-18 04:53:11 PDT
This test failed for 59652 59653 59645 59646 in a similar manner. I'm not sure how it's failing on all bots at the same time. Maybe there is some uninitialized memory being tickled here?
Jian Li
Comment 2 2010-05-18 12:42:05 PDT
Created attachment 56401 [details] Proposed Patch
Eric Seidel (no email)
Comment 3 2010-05-18 12:51:00 PDT
Comment on attachment 56401 [details] Proposed Patch WebCore/html/FileReader.cpp:237 + default: default: in a switch enum is bad, because it makes the compiler not help you. You can add an ASSERT_NOT_REACHED() to the end of the function if you'd rather. I don't really understand what this change does or why.
Jian Li
Comment 4 2010-05-18 13:21:50 PDT
Created attachment 56407 [details] Proposed Patch Added ASSERT_NOT_REACHED as suggested.
Dmitry Titov
Comment 5 2010-05-18 14:40:13 PDT
Comment on attachment 56407 [details] Proposed Patch r=me
Jian Li
Comment 6 2010-05-18 15:26:35 PDT
Note You need to log in before you can comment on or make changes to this bug.