Bug 39232 – WebKit/gtk/resources/error.html font-size error

• Component: WebKitGTK
• Status: RESOLVED FIXED

[Landry Breuil]

Created attachment 56260 [details]
Screenshot showing the error

error.html is apparently passed through a filter expanding %X constructs, so the embedded css is outputted wrong for font-size. 120% becomes 120, 80% becomes 80, and the error message is huge.
Apparently only affects epiphany to my knowledge, as other browsers seem to use their own 404 handling.

[Landry Breuil]

Created attachment 56262 [details]
Screenshot showing the error

Oops, this shot is actually the one showing the error.

[Landry Breuil]

Created attachment 56264 [details]
proposed fix

Lets' double the % so that font size gets rendered correctly.

[Landry Breuil]

Created attachment 56265 [details]
Screenshot showing the fix

[Landry Breuil]

Created attachment 131909 [details]
Double % so it doesnt get filtered out in error.html

Let's retry.

[Philippe Normand]

Comment on attachment 131909 [details]
Double % so it doesnt get filtered out in error.html

Thanks! Do you want the commit-queue to land the patch?

[Philippe Normand]

Comment on attachment 131909 [details]
Double % so it doesnt get filtered out in error.html

View in context: https://bugs.webkit.org/attachment.cgi?id=131909&action=review

> WebKit/gtk/ChangeLog:5
> +        Fix font-size in the 404 error page. Apparently the % is filtered out,
> +        so 120% becomes 120 and the error message is huge. Experienced in epiphany.
> +        https://bugs.webkit.org/show_bug.cgi?id=39232

This should be 2 lines:

bug title
bug link

The prepare-ChangeLog script can help with the entry generation if needed.

[Philippe Normand]

(In reply to comment #6)
> (From update of attachment 131909 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=131909&action=review
> 
> > WebKit/gtk/ChangeLog:5
> > +        Fix font-size in the 404 error page. Apparently the % is filtered out,
> > +        so 120% becomes 120 and the error message is huge. Experienced in epiphany.
> > +        https://bugs.webkit.org/show_bug.cgi?id=39232
> 
> This should be 2 lines:
> 
> bug title
> bug link
> 
> The prepare-ChangeLog script can help with the entry generation if needed.

And the fix description goes after the Reviewed by line :)

[Landry Breuil]

Created attachment 132103 [details]
Double % so it doesnt get filtered out in error.html

Here you are... *sigh*

[Martin Robinson]

Comment on attachment 132103 [details]
Double % so it doesnt get filtered out in error.html

Thank you! Sorry it took so long to review this patch.

[WebKit Review Bot]

Comment on attachment 132103 [details]
Double % so it doesnt get filtered out in error.html

Rejecting attachment 132103 [details] from commit-queue.

Failed to run "['/mnt/git/webkit-commit-queue/Tools/Scripts/webkit-patch', '--status-host=queues.webkit.org', '-..." exit_code: 2

Last 500 characters of output:
viewer', u'Martin Rob..." exit_code: 1 cwd: /mnt/git/webkit-commit-queue/

Parsed 2 diffs from patch file(s).
patching file WebKit/gtk/ChangeLog
Hunk #1 succeeded at 1 with fuzz 3.
patching file WebKit/gtk/resources/error.html
Hunk #1 FAILED at 21.
1 out of 1 hunk FAILED -- saving rejects to file WebKit/gtk/resources/error.html.rej

Failed to run "[u'/mnt/git/webkit-commit-queue/Tools/Scripts/svn-apply', u'--force', u'--reviewer', u'Martin Rob..." exit_code: 1 cwd: /mnt/git/webkit-commit-queue/

Full output: http://queues.webkit.org/results/11967024

[Martin Robinson]

Committed r111014: <http://trac.webkit.org/changeset/111014>

[Martin Robinson]

I'm not sure what's up with your patch. The file paths seems relative to the Source directory. I fixed it up and landed it, but in the future using Tools/Scripts/webkit-patch upload will take care of this for you. Thanks for your contribution!

[Landry Breuil]

(In reply to comment #12)
> I'm not sure what's up with your patch. The file paths seems relative to the Source directory. I fixed it up and landed it, but in the future using Tools/Scripts/webkit-patch upload will take care of this for you. Thanks for your contribution!

Well... it's a vcs, i used a vcs tool, named svn diff :) You guys use so many wrapper scripts (prepare-Changelog, now webkit-patch...), it makes the entry bar rather high for contribution... oh well, thanks for commiting it, i'll know it for the other patches i have to report :)