Bug 39223
| Summary: | webkitpy should autoinstall modules only as they are needed | ||
|---|---|---|---|
| Product: | WebKit | Reporter: | Chris Jerdonek <cjerdonek> |
| Component: | Tools / Tests | Assignee: | Nobody <webkit-unassigned> |
| Status: | RESOLVED FIXED | ||
| Severity: | Normal | CC: | abarth, eric, mjs, webkit-bug-importer |
| Priority: | P2 | Keywords: | InRadar |
| Version: | 528+ (Nightly build) | ||
| Hardware: | All | ||
| OS: | All | ||
Chris Jerdonek
webkitpy should not necessarily autoinstall every module needed by every script. It should autoinstall only modules as they are needed.
This is the corresponding FIXME in the code:
http://trac.webkit.org/browser/trunk/WebKitTools/Scripts/webkitpy/thirdparty/__init__.py?rev=59350#L39
Fixing this probably means adding a custom import hook like the old autoinstall module. That should let us globally detect whenever an autoinstallable module is being imported from.
| Attachments | ||
|---|---|---|
| Add attachment proposed patch, testcase, etc. |
Sam Sneddon [:gsnedders]
We're certainly doing this with the current autoinstaller, and the previous one was removed in Bug 218131.
Radar WebKit Bug Importer
<rdar://problem/139331533>