Summary: | Add an optional "starting node' parameter to scrollRecursively and scrollOverflow of EventHandler | ||||||||||||
---|---|---|---|---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Antonio Gomes <tonikitoo> | ||||||||||
Component: | WebCore Misc. | Assignee: | Antonio Gomes <tonikitoo> | ||||||||||
Status: | CLOSED FIXED | ||||||||||||
Severity: | Enhancement | CC: | abarth, darin, eric, hausmann, webkit.review.bot | ||||||||||
Priority: | P2 | ||||||||||||
Version: | 528+ (Nightly build) | ||||||||||||
Hardware: | PC | ||||||||||||
OS: | All | ||||||||||||
Bug Depends on: | 18662 | ||||||||||||
Bug Blocks: | 39195 | ||||||||||||
Attachments: |
|
Description
Antonio Gomes
2010-05-17 07:06:06 PDT
Created attachment 56241 [details]
patch v1
Created attachment 56242 [details]
patch v2
And the right/newer/working version of the patch.
(In reply to comment #2) > Created an attachment (id=56242) [details] > patch v2 Darin, could you please help me with this patch? Call site and layout test is in attachment https://bug-39195-attachments.webkit.org/attachment.cgi?id=56249 Comment on attachment 56242 [details]
patch v2
I don't think the name "fromNode" is clear enough. Argument names should be noun phrases; there's no such thing as a "from node". Maybe "starting node" is the right name?
Created attachment 56250 [details] patch v2.1 (In reply to comment #4) > (From update of attachment 56242 [details]) > I don't think the name "fromNode" is clear enough. Argument names should be noun phrases; there's no such thing as a "from node". Maybe "starting node" is the right name? Same as patch v2, but changed "fromNode" to 'startingNode" Comment on attachment 56250 [details] patch v2.1 > + bool scrollRecursively(ScrollDirection, ScrollGranularity, Node* fromNode = 0); Forgot to change names here. Created attachment 56251 [details] (committed with r60159, reviewed by darin adler) patch v2.2 Changed missing bits of patch 2.1, as per Darin's request. Comment on attachment 56251 [details] (committed with r60159, reviewed by darin adler) patch v2.2 Clearing flags on attachment: 56251 Committed r60159: <http://trac.webkit.org/changeset/60159> http://trac.webkit.org/changeset/60159 might have broken GTK Linux 32-bit Release The following changes are on the blame list: http://trac.webkit.org/changeset/60158 http://trac.webkit.org/changeset/60159 Revision r60159 cherry-picked into qtwebkit-2.0 with commit 146d466226932322e6f6242b083372a6ab502e80 |